[java]: javacc in the build

[Gordon Sim <gs...@redhat.com>]

Attached is a suggested patch for the build (on trunk) to use the javacc 
jar included in the lib folder, rather than requiring javacc to be 
installed separately and on the path. I think this is more convenient; 
does it break things for anyone else?

Re: [java]: javacc in the build

[Rafael Schloming <ra...@redhat.com>]

Gordon Sim wrote:
> Attached is a suggested patch for the build (on trunk) to use the javacc 
> jar included in the lib folder, rather than requiring javacc to be 
> installed separately and on the path. I think this is more convenient; 
> does it break things for anyone else?

Actually the javacc task has been part of ant at least as far back as 
1.6.0. I'm not sure why this particular change was necessary in the 
first place. I suspect the version in the original build file will work 
anywhere we care about unless we're targeting particularly old versions 
of ant.

--Rafael

Re: [java]: javacc in the build

[Craig L Russell <Cr...@Sun.COM>]

Since javacc has a separate license, if you plan to distribute it as  
part of a release, make sure it's NOTICEd in distributions.

Craig

On Apr 2, 2008, at 4:18 AM, Gordon Sim wrote:

> Attached is a suggested patch for the build (on trunk) to use the  
> javacc jar included in the lib folder, rather than requiring javacc  
> to be installed separately and on the path. I think this is more  
> convenient; does it break things for anyone else?
>
> Index: broker/build.xml
> ===================================================================
> --- broker/build.xml	(revision 643813)
> +++ broker/build.xml	(working copy)
> @@ -30,9 +30,10 @@
>
>   <target name="precompile">
>     <mkdir dir="${output.dir}"/>
> -    <exec executable="javacc">
> -      <arg line="-OUTPUT_DIRECTORY=${output.dir} src/main/grammar/ 
> SelectorParser.jj"/>
> -    </exec>
> +    <java classpath="../lib/javacc.jar" classname="javacc">
> +      <arg value="-OUTPUT_DIRECTORY=${output.dir}"/>
> +      <arg file="src/main/grammar/SelectorParser.jj"/>
> +    </java>
>   </target>
>
> </project>

Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:Craig.Russell@sun.com
P.S. A good JDO? O, Gasp!