You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/14 05:41:30 UTC

[GitHub] [incubator-superset] rusackas commented on a change in pull request #11254: chore: Added data-test attributes for testing

rusackas commented on a change in pull request #11254:
URL: https://github.com/apache/incubator-superset/pull/11254#discussion_r504414106



##########
File path: superset-frontend/package-lock.json
##########
@@ -21137,8 +21137,7 @@
               "version": "2.1.1",
               "resolved": "",
               "integrity": "sha1-w7M6te42DYbg5ijwRorn7yfWVN8=",
-              "dev": true,

Review comment:
       FWIW, I'm not sure what others do, but I just don't bother committing `package-lock.json` if `package.json` hasn't changed. The thrashing of this file doesn't _usually_ seem to make any notable difference other than some occasional merge conflicts. :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org