You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/05/27 08:34:40 UTC

[GitHub] [incubator-superset] codecov-commenter commented on pull request #9924: feat: Excel file export

codecov-commenter commented on pull request #9924:
URL: https://github.com/apache/incubator-superset/pull/9924#issuecomment-634514074


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=h1) Report
   > Merging [#9924](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9edfc8f68dbc6f5c1c996e7c1fe3b84e6561a068&el=desc) will **decrease** coverage by `0.37%`.
   > The diff coverage is `20.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9924/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9924      +/-   ##
   ==========================================
   - Coverage   71.22%   70.84%   -0.38%     
   ==========================================
     Files         585      184     -401     
     Lines       30828    18060   -12768     
     Branches     3237        0    -3237     
   ==========================================
   - Hits        21957    12795    -9162     
   + Misses       8762     5265    -3497     
   + Partials      109        0     -109     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `70.84% <20.00%> (-0.56%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.06% <ø> (-0.02%)` | :arrow_down: |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.42% <16.66%> (-2.64%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.63% <25.00%> (-0.35%)` | :arrow_down: |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `89.71% <100.00%> (+0.04%)` | :arrow_up: |
   | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.36% <100.00%> (-0.09%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
   | [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `48.00% <0.00%> (-20.00%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `77.77% <0.00%> (-5.56%)` | :arrow_down: |
   | ... and [426 more](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=footer). Last update [9edfc8f...438ab2e](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org