You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "Yicong-Huang (via GitHub)" <gi...@apache.org> on 2026/05/02 07:05:54 UTC
[PR] chore(asf): require conversation resolution before merge [texera]
Yicong-Huang opened a new pull request, #4660:
URL: https://github.com/apache/texera/pull/4660
## Summary
- Add `required_conversation_resolution: true` to `main` branch protection in `.asf.yaml` so PR review threads must be marked Resolved before merge.
- Aligns with 40 other Apache repos already using this field (airflow, pulsar, log4j2, cloudberry, fineract, ignite-3, nuttx, etc.).
Closes #4659.
## Test plan
- [ ] After merge, ASF INFRA bot syncs `.asf.yaml` to GitHub branch protection on `main`.
- [ ] Open a test PR with an unresolved inline comment — confirm merge button is blocked until the thread is resolved.
- [ ] Approval flow unchanged (1 approval still required).
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(asf): require conversation resolution before merge [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on code in PR #4660:
URL: https://github.com/apache/texera/pull/4660#discussion_r3176307461
##########
.asf.yaml:
##########
@@ -77,6 +77,7 @@ github:
require_code_owner_reviews: false
required_approving_review_count: 1
required_linear_history: true
+ required_conversation_resolution: true
Review Comment:
This comment doesn't block the merge. Maybe it only works after merging to main?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(asf): require conversation resolution before merge [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4660:
URL: https://github.com/apache/texera/pull/4660#issuecomment-4363274957
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/4660?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:warning: Please [upload](https://docs.codecov.com/docs/codecov-uploader) report for BASE (`main@5c7dac8`). [Learn more](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#section-missing-base-commit) about missing BASE report.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #4660 +/- ##
=======================================
Coverage ? 28.73%
=======================================
Files ? 20
Lines ? 3320
Branches ? 0
=======================================
Hits ? 954
Misses ? 2366
Partials ? 0
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/4660/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/4660/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `28.73% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/texera/pull/4660?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(asf): require conversation resolution before merge [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on code in PR #4660:
URL: https://github.com/apache/texera/pull/4660#discussion_r3176306667
##########
.asf.yaml:
##########
@@ -77,6 +77,7 @@ github:
require_code_owner_reviews: false
required_approving_review_count: 1
required_linear_history: true
+ required_conversation_resolution: true
Review Comment:
Let me try to test it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(asf): require conversation resolution before merge [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang merged PR #4660:
URL: https://github.com/apache/texera/pull/4660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(asf): require conversation resolution before merge [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on code in PR #4660:
URL: https://github.com/apache/texera/pull/4660#discussion_r3176310629
##########
.asf.yaml:
##########
@@ -77,6 +77,7 @@ github:
require_code_owner_reviews: false
required_approving_review_count: 1
required_linear_history: true
+ required_conversation_resolution: true
Review Comment:
yes. any asf configs only takes effect on main. so it is tricky and dangerous to change .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org