You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/12/05 23:32:53 UTC
Re: Review Request 14434: Added list of TaskStatuses to Task message.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14434/#review29842
-----------------------------------------------------------
When we create Tasks (e.g. in Master::launchTask) we should add a corresponding status for the Task, can you take that up in a subsequent patch?
There are a few spots in the master/slave where a task is created with no corresponding status. Would potentially be easiest if we delegated task creation to a protobuf_utils:: function that always adds a status.
- Ben Mahler
On Nov. 14, 2013, 7:16 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14434/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2013, 7:16 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added list of TaskStatuses to Task message.
>
> Task now includes repeated task status with timestamps. This permits
> caltulating the start/finish time for tasks (among other things).
>
> To support this, a timestamp was added to the TaskStatus message which
> is also passed to frameworks when there are state transitions.
>
> Review: https://reviews.apache.org/r/14434
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto ad4ba5bb618d4c9e107e288566852f54da6ceea5
> src/common/protobuf_utils.hpp 19a49ab1cb212b454394b78ffedeb9a7eb6b8964
> src/exec/exec.cpp 4a598f52bd9f97eeb14d9700e05281ccc1650c14
> src/master/http.cpp f2a535a002f07784db724f6fdedfb26b271d6327
> src/master/master.cpp 8e14a070e87ebe579b54d05fb1e8b286edb5e459
> src/messages/messages.proto a5dded2c0f3f88a5f7d789ccde6e59f68880374b
> src/slave/slave.hpp 68526f3fb01be6dc19d7e3c8e4ba8220b2c56ccb
> src/slave/slave.cpp 13cb41828298a725ee94a900a63dd8626f315e7e
> src/webui/master/static/framework.html 6e5cd9f9e48597c7894d6381377c8a291014e8f3
> src/webui/master/static/frameworks.html 7c243d47d80e7c74fcac938d012b91b67b995490
> src/webui/master/static/js/controllers.js 8f65679ff4f82f570cf7d632e45ca7dbcfab3376
>
> Diff: https://reviews.apache.org/r/14434/diff/
>
>
> Testing
> -------
>
> `make check`, tested in staging, and manual web UI testing.
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request 14434: Added list of TaskStatuses to Task message.
Posted by Ben Mahler <be...@gmail.com>.
> On Dec. 5, 2013, 10:32 p.m., Ben Mahler wrote:
> > When we create Tasks (e.g. in Master::launchTask) we should add a corresponding status for the Task, can you take that up in a subsequent patch?
> >
> > There are a few spots in the master/slave where a task is created with no corresponding status. Would potentially be easiest if we delegated task creation to a protobuf_utils:: function that always adds a status.
We've got https://issues.apache.org/jira/browse/MESOS-869 targeted for 0.17.0 if you'd like to take it :)
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14434/#review29842
-----------------------------------------------------------
On Nov. 14, 2013, 7:16 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14434/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2013, 7:16 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added list of TaskStatuses to Task message.
>
> Task now includes repeated task status with timestamps. This permits
> caltulating the start/finish time for tasks (among other things).
>
> To support this, a timestamp was added to the TaskStatus message which
> is also passed to frameworks when there are state transitions.
>
> Review: https://reviews.apache.org/r/14434
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto ad4ba5bb618d4c9e107e288566852f54da6ceea5
> src/common/protobuf_utils.hpp 19a49ab1cb212b454394b78ffedeb9a7eb6b8964
> src/exec/exec.cpp 4a598f52bd9f97eeb14d9700e05281ccc1650c14
> src/master/http.cpp f2a535a002f07784db724f6fdedfb26b271d6327
> src/master/master.cpp 8e14a070e87ebe579b54d05fb1e8b286edb5e459
> src/messages/messages.proto a5dded2c0f3f88a5f7d789ccde6e59f68880374b
> src/slave/slave.hpp 68526f3fb01be6dc19d7e3c8e4ba8220b2c56ccb
> src/slave/slave.cpp 13cb41828298a725ee94a900a63dd8626f315e7e
> src/webui/master/static/framework.html 6e5cd9f9e48597c7894d6381377c8a291014e8f3
> src/webui/master/static/frameworks.html 7c243d47d80e7c74fcac938d012b91b67b995490
> src/webui/master/static/js/controllers.js 8f65679ff4f82f570cf7d632e45ca7dbcfab3376
>
> Diff: https://reviews.apache.org/r/14434/diff/
>
>
> Testing
> -------
>
> `make check`, tested in staging, and manual web UI testing.
>
>
> Thanks,
>
> Brenden Matthews
>
>