You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "NihalJain (via GitHub)" <gi...@apache.org> on 2025/01/07 20:48:35 UTC
[PR] HBASE-29063 [hbase-thirdparty] Document steps to generate patches for protobuf-java [hbase-thirdparty]
NihalJain opened a new pull request, #128:
URL: https://github.com/apache/hbase-thirdparty/pull/128
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29063 [hbase-thirdparty] Document steps to generate patches for protobuf-java [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain merged PR #128:
URL: https://github.com/apache/hbase-thirdparty/pull/128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29063 [hbase-thirdparty] Document steps to generate patches for protobuf-java [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #128:
URL: https://github.com/apache/hbase-thirdparty/pull/128#issuecomment-2576213558
Hi @Apache9 I have added documentation on how to generate patches for google-protobuf based on my current understanding. It was a gray area for me for a long time, I think there would be others too who may also not be aware of exact steps. This might come handy to those folks in future. Please go over the steps and let me know if this sounds right.
My assumption is if code builds fine we do not need to follow these steps at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29063 [hbase-thirdparty] Document steps to generate patches for protobuf-java [hbase-thirdparty]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #128:
URL: https://github.com/apache/hbase-thirdparty/pull/128#issuecomment-2577274977
Small nit change, updated path to include 'hbase-shaded-protobuf'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org