You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by subin m <su...@apache.org> on 2014/06/30 15:30:44 UTC
Review Request 23167: AMBARI-6316 Python client improvements
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23167/
-----------------------------------------------------------
Review request for Ambari, Erin Boyd and Mahadev Konar.
Repository: ambari
Description
-------
python client changes
1)PEP8 formatting
2)support more apis
Diffs
-----
ambari-client/python-client/pom.xml 8438b80
ambari-client/python-client/src/main/python/ambari_client/ambari_api.py daf5e1e
ambari-client/python-client/src/main/python/ambari_client/core/coreutils.py d3e1b4f
ambari-client/python-client/src/main/python/ambari_client/core/errors.py c691241
ambari-client/python-client/src/main/python/ambari_client/core/http_client.py 484ef5d
ambari-client/python-client/src/main/python/ambari_client/core/http_utils.py 07fea45
ambari-client/python-client/src/main/python/ambari_client/core/rest_resource.py 532fc53
ambari-client/python-client/src/main/python/ambari_client/model/base_model.py 79fd9ad
ambari-client/python-client/src/main/python/ambari_client/model/blueprint.py PRE-CREATION
ambari-client/python-client/src/main/python/ambari_client/model/cluster.py 4a8cce6
ambari-client/python-client/src/main/python/ambari_client/model/component.py 586f21a
ambari-client/python-client/src/main/python/ambari_client/model/configuration.py 883caf2
ambari-client/python-client/src/main/python/ambari_client/model/host.py f261deb
ambari-client/python-client/src/main/python/ambari_client/model/paths.py f34c26d
ambari-client/python-client/src/main/python/ambari_client/model/service.py ed91d7c
ambari-client/python-client/src/main/python/ambari_client/model/stack.py 40088f7
ambari-client/python-client/src/main/python/ambari_client/model/status.py f88a534
ambari-client/python-client/src/main/python/ambari_client/model/utils.py 0b3b6a0
ambari-client/python-client/src/main/python/ambari_client/model/views.py PRE-CREATION
ambari-client/python-client/src/main/python/ambari_client/resources/__init__.py 278df2e
ambari-client/python-client/src/main/python/ambari_client/resources/clusters.py ca3cca6
ambari-client/python-client/src/main/python/ambari_client/resources/hosts.py 0d53711
ambari-client/python-client/src/main/python/ambari_client/resources/stacks.py f4ef518
ambari-client/python-client/src/test/python/TestAmbariClient.py 1831f89
ambari-client/python-client/src/test/python/TestStatusModel.py 7f88771
Diff: https://reviews.apache.org/r/23167/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Client ..................................... SUCCESS [1.746s]
[INFO] Ambari Python Client .............................. SUCCESS [1.985s]
[INFO] Ambari Groovy Client .............................. SUCCESS [11.666s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 15.869s
[INFO] Finished at: Mon Jun 30 18:12:12 IST 2014
[INFO] Final Memory: 25M/424M
[INFO] ------------------------------------------------------------------------
Thanks,
subin m
Re: Review Request 23167: AMBARI-6316 Python client improvements
Posted by Erin Boyd <eb...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23167/#review46978
-----------------------------------------------------------
Ship it!
Ship It!
- Erin Boyd
On June 30, 2014, 1:30 p.m., subin m wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23167/
> -----------------------------------------------------------
>
> (Updated June 30, 2014, 1:30 p.m.)
>
>
> Review request for Ambari, Erin Boyd and Mahadev Konar.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> python client changes
> 1)PEP8 formatting
> 2)support more apis
>
>
> Diffs
> -----
>
> ambari-client/python-client/pom.xml 8438b80
> ambari-client/python-client/src/main/python/ambari_client/ambari_api.py daf5e1e
> ambari-client/python-client/src/main/python/ambari_client/core/coreutils.py d3e1b4f
> ambari-client/python-client/src/main/python/ambari_client/core/errors.py c691241
> ambari-client/python-client/src/main/python/ambari_client/core/http_client.py 484ef5d
> ambari-client/python-client/src/main/python/ambari_client/core/http_utils.py 07fea45
> ambari-client/python-client/src/main/python/ambari_client/core/rest_resource.py 532fc53
> ambari-client/python-client/src/main/python/ambari_client/model/base_model.py 79fd9ad
> ambari-client/python-client/src/main/python/ambari_client/model/blueprint.py PRE-CREATION
> ambari-client/python-client/src/main/python/ambari_client/model/cluster.py 4a8cce6
> ambari-client/python-client/src/main/python/ambari_client/model/component.py 586f21a
> ambari-client/python-client/src/main/python/ambari_client/model/configuration.py 883caf2
> ambari-client/python-client/src/main/python/ambari_client/model/host.py f261deb
> ambari-client/python-client/src/main/python/ambari_client/model/paths.py f34c26d
> ambari-client/python-client/src/main/python/ambari_client/model/service.py ed91d7c
> ambari-client/python-client/src/main/python/ambari_client/model/stack.py 40088f7
> ambari-client/python-client/src/main/python/ambari_client/model/status.py f88a534
> ambari-client/python-client/src/main/python/ambari_client/model/utils.py 0b3b6a0
> ambari-client/python-client/src/main/python/ambari_client/model/views.py PRE-CREATION
> ambari-client/python-client/src/main/python/ambari_client/resources/__init__.py 278df2e
> ambari-client/python-client/src/main/python/ambari_client/resources/clusters.py ca3cca6
> ambari-client/python-client/src/main/python/ambari_client/resources/hosts.py 0d53711
> ambari-client/python-client/src/main/python/ambari_client/resources/stacks.py f4ef518
> ambari-client/python-client/src/test/python/TestAmbariClient.py 1831f89
> ambari-client/python-client/src/test/python/TestStatusModel.py 7f88771
>
> Diff: https://reviews.apache.org/r/23167/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Client ..................................... SUCCESS [1.746s]
> [INFO] Ambari Python Client .............................. SUCCESS [1.985s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [11.666s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15.869s
> [INFO] Finished at: Mon Jun 30 18:12:12 IST 2014
> [INFO] Final Memory: 25M/424M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> subin m
>
>
Re: Review Request 23167: AMBARI-6316 Python client improvements
Posted by subin m <su...@apache.org>.
> On June 30, 2014, 1:37 p.m., Erin Boyd wrote:
> > Why did you back version this:
> > <artifactId>rpm-maven-plugin</artifactId>
> > - <version>2.1-alpha-2</version>
> > + <version>2.0.1</version>
> > <executions>
2.0.1 is the stable version used in Ambari.
Adding 2.1-alpha-2 was a mistake
- subin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23167/#review46976
-----------------------------------------------------------
On June 30, 2014, 1:30 p.m., subin m wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23167/
> -----------------------------------------------------------
>
> (Updated June 30, 2014, 1:30 p.m.)
>
>
> Review request for Ambari, Erin Boyd and Mahadev Konar.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> python client changes
> 1)PEP8 formatting
> 2)support more apis
>
>
> Diffs
> -----
>
> ambari-client/python-client/pom.xml 8438b80
> ambari-client/python-client/src/main/python/ambari_client/ambari_api.py daf5e1e
> ambari-client/python-client/src/main/python/ambari_client/core/coreutils.py d3e1b4f
> ambari-client/python-client/src/main/python/ambari_client/core/errors.py c691241
> ambari-client/python-client/src/main/python/ambari_client/core/http_client.py 484ef5d
> ambari-client/python-client/src/main/python/ambari_client/core/http_utils.py 07fea45
> ambari-client/python-client/src/main/python/ambari_client/core/rest_resource.py 532fc53
> ambari-client/python-client/src/main/python/ambari_client/model/base_model.py 79fd9ad
> ambari-client/python-client/src/main/python/ambari_client/model/blueprint.py PRE-CREATION
> ambari-client/python-client/src/main/python/ambari_client/model/cluster.py 4a8cce6
> ambari-client/python-client/src/main/python/ambari_client/model/component.py 586f21a
> ambari-client/python-client/src/main/python/ambari_client/model/configuration.py 883caf2
> ambari-client/python-client/src/main/python/ambari_client/model/host.py f261deb
> ambari-client/python-client/src/main/python/ambari_client/model/paths.py f34c26d
> ambari-client/python-client/src/main/python/ambari_client/model/service.py ed91d7c
> ambari-client/python-client/src/main/python/ambari_client/model/stack.py 40088f7
> ambari-client/python-client/src/main/python/ambari_client/model/status.py f88a534
> ambari-client/python-client/src/main/python/ambari_client/model/utils.py 0b3b6a0
> ambari-client/python-client/src/main/python/ambari_client/model/views.py PRE-CREATION
> ambari-client/python-client/src/main/python/ambari_client/resources/__init__.py 278df2e
> ambari-client/python-client/src/main/python/ambari_client/resources/clusters.py ca3cca6
> ambari-client/python-client/src/main/python/ambari_client/resources/hosts.py 0d53711
> ambari-client/python-client/src/main/python/ambari_client/resources/stacks.py f4ef518
> ambari-client/python-client/src/test/python/TestAmbariClient.py 1831f89
> ambari-client/python-client/src/test/python/TestStatusModel.py 7f88771
>
> Diff: https://reviews.apache.org/r/23167/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Client ..................................... SUCCESS [1.746s]
> [INFO] Ambari Python Client .............................. SUCCESS [1.985s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [11.666s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15.869s
> [INFO] Finished at: Mon Jun 30 18:12:12 IST 2014
> [INFO] Final Memory: 25M/424M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> subin m
>
>
Re: Review Request 23167: AMBARI-6316 Python client improvements
Posted by Erin Boyd <eb...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23167/#review46976
-----------------------------------------------------------
Why did you back version this:
<artifactId>rpm-maven-plugin</artifactId>
- <version>2.1-alpha-2</version>
+ <version>2.0.1</version>
<executions>
- Erin Boyd
On June 30, 2014, 1:30 p.m., subin m wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23167/
> -----------------------------------------------------------
>
> (Updated June 30, 2014, 1:30 p.m.)
>
>
> Review request for Ambari, Erin Boyd and Mahadev Konar.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> python client changes
> 1)PEP8 formatting
> 2)support more apis
>
>
> Diffs
> -----
>
> ambari-client/python-client/pom.xml 8438b80
> ambari-client/python-client/src/main/python/ambari_client/ambari_api.py daf5e1e
> ambari-client/python-client/src/main/python/ambari_client/core/coreutils.py d3e1b4f
> ambari-client/python-client/src/main/python/ambari_client/core/errors.py c691241
> ambari-client/python-client/src/main/python/ambari_client/core/http_client.py 484ef5d
> ambari-client/python-client/src/main/python/ambari_client/core/http_utils.py 07fea45
> ambari-client/python-client/src/main/python/ambari_client/core/rest_resource.py 532fc53
> ambari-client/python-client/src/main/python/ambari_client/model/base_model.py 79fd9ad
> ambari-client/python-client/src/main/python/ambari_client/model/blueprint.py PRE-CREATION
> ambari-client/python-client/src/main/python/ambari_client/model/cluster.py 4a8cce6
> ambari-client/python-client/src/main/python/ambari_client/model/component.py 586f21a
> ambari-client/python-client/src/main/python/ambari_client/model/configuration.py 883caf2
> ambari-client/python-client/src/main/python/ambari_client/model/host.py f261deb
> ambari-client/python-client/src/main/python/ambari_client/model/paths.py f34c26d
> ambari-client/python-client/src/main/python/ambari_client/model/service.py ed91d7c
> ambari-client/python-client/src/main/python/ambari_client/model/stack.py 40088f7
> ambari-client/python-client/src/main/python/ambari_client/model/status.py f88a534
> ambari-client/python-client/src/main/python/ambari_client/model/utils.py 0b3b6a0
> ambari-client/python-client/src/main/python/ambari_client/model/views.py PRE-CREATION
> ambari-client/python-client/src/main/python/ambari_client/resources/__init__.py 278df2e
> ambari-client/python-client/src/main/python/ambari_client/resources/clusters.py ca3cca6
> ambari-client/python-client/src/main/python/ambari_client/resources/hosts.py 0d53711
> ambari-client/python-client/src/main/python/ambari_client/resources/stacks.py f4ef518
> ambari-client/python-client/src/test/python/TestAmbariClient.py 1831f89
> ambari-client/python-client/src/test/python/TestStatusModel.py 7f88771
>
> Diff: https://reviews.apache.org/r/23167/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Client ..................................... SUCCESS [1.746s]
> [INFO] Ambari Python Client .............................. SUCCESS [1.985s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [11.666s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15.869s
> [INFO] Finished at: Mon Jun 30 18:12:12 IST 2014
> [INFO] Final Memory: 25M/424M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> subin m
>
>