You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2018/08/07 19:45:31 UTC
Review Request 68262: Removed unused operator overloads in
`Resources`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68262/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
`Resources::operator+(Resource_)` (and minus counterparts) are
currently not used. This patch removes these overloads.
Diffs
-----
include/mesos/resources.hpp 6d81d0e25827db5a165a211ccbea804047db7989
include/mesos/v1/resources.hpp f34f38fe25b295306210587f8de8372ebf4ca8e2
src/common/resources.cpp cef2acd565911fc59e751c3135675515b2e22c59
src/v1/resources.cpp aa775bd361752bd890a0474eca613b2bccfc5275
Diff: https://reviews.apache.org/r/68262/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 68262: Removed unused operator overloads in
`Resources`.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68262/#review206959
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On Aug. 7, 2018, 7:45 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68262/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2018, 7:45 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `Resources::operator+(Resource_)` (and minus counterparts) are
> currently not used. This patch removes these overloads.
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 6d81d0e25827db5a165a211ccbea804047db7989
> include/mesos/v1/resources.hpp f34f38fe25b295306210587f8de8372ebf4ca8e2
> src/common/resources.cpp cef2acd565911fc59e751c3135675515b2e22c59
> src/v1/resources.cpp aa775bd361752bd890a0474eca613b2bccfc5275
>
>
> Diff: https://reviews.apache.org/r/68262/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 68262: Removed unused operator overloads in
`Resources`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68262/#review206956
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['68262']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2116/mesos-review-68262
Relevant logs:
- [libprocess-tests-cmake.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2116/mesos-review-68262/logs/libprocess-tests-cmake.log):
```
cl : Command line warning D9002: ignoring unknown option '-fPIC' [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj] [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(1415): warning C4244: '+=': conversion from '__int64' to 'uint32_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj] [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(1520): warning C4244: '+=': conversion from '__int64' to 'uint32_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj] [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(1689): warning C4244: '+=': conversion from '__int64' to 'uint32_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj] [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2273): warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj] [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2280): warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj] [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2292): warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj] [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2301): warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj] [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2401): warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj] [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
cl : Command line warning D9002: ignoring unknown option '-fPIC' [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj] [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(1415): warning C4244: '+=': conversion from '__int64' to 'uint32_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj] [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(1520): warning C4244: '+=': conversion from '__int64' to 'uint32_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj] [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(1689): warning C4244: '+=': conversion from '__int64' to 'uint32_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj] [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2273): warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj] [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2280): warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj] [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2292): warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj] [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2301): warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj] [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2401): warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj] [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
"D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj" (default target) (3) ->
(ClCompile target) ->
d:\dcos\mesos\mesos\3rdparty\libprocess\src\tests\benchmarks.cpp(879): error C3493: 'messageCount' cannot be implicitly captured because no default capture mode has been specified [D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj]
31 Warning(s)
1 Error(s)
Time Elapsed 00:07:24.95
```
- Mesos Reviewbot Windows
On Aug. 7, 2018, 7:45 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68262/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2018, 7:45 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `Resources::operator+(Resource_)` (and minus counterparts) are
> currently not used. This patch removes these overloads.
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 6d81d0e25827db5a165a211ccbea804047db7989
> include/mesos/v1/resources.hpp f34f38fe25b295306210587f8de8372ebf4ca8e2
> src/common/resources.cpp cef2acd565911fc59e751c3135675515b2e22c59
> src/v1/resources.cpp aa775bd361752bd890a0474eca613b2bccfc5275
>
>
> Diff: https://reviews.apache.org/r/68262/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>