[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #423: [FLINK-27844] Support column type evolution in file meta

[GitBox <gi...@apache.org>]

JingsongLi commented on code in PR #423:
URL: https://github.com/apache/flink-table-store/pull/423#discussion_r1060497684


##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/casting/CastExecutors.java:
##########
@@ -176,7 +176,7 @@ public class CastExecutors {
                 }
                 return null;
             case BINARY:
-                if (outputType.getTypeRoot() == BINARY) {
+                if (outputType.getTypeRoot() == BINARY || outputType.getTypeRoot() == VARBINARY) {

Review Comment:
   I think we should not use this code. Here should something like Char and Varchar.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org