You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by GitBox <gi...@apache.org> on 2022/02/06 11:24:46 UTC

[GitHub] [struts] lukaszlenart opened a new pull request #529: [WW-5016] Adds support for LocalDate and adjusts tests to use the new Java 8 API

lukaszlenart opened a new pull request #529:
URL: https://github.com/apache/struts/pull/529


   Relates to [WW-5016](https://issues.apache.org/jira/browse/WW-5016)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org

[GitHub] [struts] coveralls edited a comment on pull request #529: [WW-5016] Adds support for LocalDate and adjusts tests to use the new Java 8 API

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #529:
URL: https://github.com/apache/struts/pull/529#issuecomment-1030815732


   
   [![Coverage Status](https://coveralls.io/builds/46723053/badge)](https://coveralls.io/builds/46723053)
   
   Coverage increased (+0.02%) to 50.583% when pulling **4746a49d177baee9d99acd243c2aec627828b2bc on WW-5016-uses-proper-format** into **f0b24d17da4751666f12bc498c73c20d91e29558 on master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [struts] coveralls commented on pull request #529: [WW-5016] Adds support for LocalDate and adjusts tests to use the new Java 8 API

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #529:
URL: https://github.com/apache/struts/pull/529#issuecomment-1030815732


   
   [![Coverage Status](https://coveralls.io/builds/46265049/badge)](https://coveralls.io/builds/46265049)
   
   Coverage increased (+0.002%) to 50.563% when pulling **804e1546f149174f6e88d69b77bd3fa9e8b9a76d on WW-5016-uses-proper-format** into **f0b24d17da4751666f12bc498c73c20d91e29558 on master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [struts] lukaszlenart commented on pull request #529: [WW-5016] Adds support for LocalDate and adjusts tests to use the new Java 8 API

Posted by GitBox <gi...@apache.org>.
lukaszlenart commented on pull request #529:
URL: https://github.com/apache/struts/pull/529#issuecomment-1046228304


   Done, I've extended the change to use to a formatter injected by the framework based on user choice.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [struts] lukaszlenart commented on pull request #529: [WW-5016] Adds support for LocalDate and adjusts tests to use the new Java 8 API

Posted by GitBox <gi...@apache.org>.
lukaszlenart commented on pull request #529:
URL: https://github.com/apache/struts/pull/529#issuecomment-1046220750


   I'm working on a version which uses `@Inject` to inject a porper formatter.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [struts] coveralls edited a comment on pull request #529: [WW-5016] Adds support for LocalDate and adjusts tests to use the new Java 8 API

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #529:
URL: https://github.com/apache/struts/pull/529#issuecomment-1030815732


   
   [![Coverage Status](https://coveralls.io/builds/46711916/badge)](https://coveralls.io/builds/46711916)
   
   Coverage increased (+0.01%) to 50.575% when pulling **5648721d07b483427ed00c4315b91f45cd359918 on WW-5016-uses-proper-format** into **f0b24d17da4751666f12bc498c73c20d91e29558 on master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [struts] lukaszlenart merged pull request #529: [WW-5016] Adds support for LocalDate and adjusts tests to use the new Java 8 API

Posted by GitBox <gi...@apache.org>.
lukaszlenart merged pull request #529:
URL: https://github.com/apache/struts/pull/529


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org

[GitHub] [struts] lukaszlenart commented on pull request #529: [WW-5016] Adds support for LocalDate and adjusts tests to use the new Java 8 API

Posted by GitBox <gi...@apache.org>.
lukaszlenart commented on pull request #529:
URL: https://github.com/apache/struts/pull/529#issuecomment-1037952530


   Hm... I can implement a flag to either use a new or an old formatting mechanism. Yet this will introduce unnecessary complexity and I think it's a good moment to break backward compatibility while releasing a new major version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [struts] lukaszlenart commented on pull request #529: [WW-5016] Adds support for LocalDate and adjusts tests to use the new Java 8 API

Posted by GitBox <gi...@apache.org>.
lukaszlenart commented on pull request #529:
URL: https://github.com/apache/struts/pull/529#issuecomment-1037952530


   Hm... I can implement a flag to either use a new or an old formatting mechanism. Yet this will introduce unnecessary complexity and I think it's a good moment to break backward compatibility while releasing a new major version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [struts] coveralls edited a comment on pull request #529: [WW-5016] Adds support for LocalDate and adjusts tests to use the new Java 8 API

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #529:
URL: https://github.com/apache/struts/pull/529#issuecomment-1030815732


   
   [![Coverage Status](https://coveralls.io/builds/46744461/badge)](https://coveralls.io/builds/46744461)
   
   Coverage increased (+0.02%) to 50.583% when pulling **59932a51799890582859938a355546b75b5f6834 on WW-5016-uses-proper-format** into **f0b24d17da4751666f12bc498c73c20d91e29558 on master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org