You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2016/02/02 18:18:22 UTC
Re: Review Request 43022: Added protobuf fields for docker runtime
isolator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43022/
-----------------------------------------------------------
(Updated Feb. 2, 2016, 9:18 a.m.)
Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
Bugs: MESOS-4517
https://issues.apache.org/jira/browse/MESOS-4517
Repository: mesos
Description
-------
Added protobuf fields for docker runtime isolator.
Diffs
-----
include/mesos/slave/isolator.proto 8b7c54afc4467084b5d22387e55689d06078b504
Diff: https://reviews.apache.org/r/43022/diff/
Testing
-------
make check (ubuntu14.04 + clang-3.6)
Thanks,
Gilbert Song
Re: Review Request 43022: Added protobuf fields for docker runtime
isolator.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43022/#review117442
-----------------------------------------------------------
include/mesos/slave/isolator.proto (line 85)
<https://reviews.apache.org/r/43022/#comment178624>
Why 'required' here. I would rather keep it 'optional' in case in the future, we have v2/v3/v4 manifest.
include/mesos/slave/isolator.proto (line 105)
<https://reviews.apache.org/r/43022/#comment178628>
This is not docker specific right?
include/mesos/slave/isolator.proto (lines 108 - 111)
<https://reviews.apache.org/r/43022/#comment178630>
```
If specified, it'll become the launch command for the custom executor, or the launch command for the user task in the case of a command task.
```
include/mesos/slave/isolator.proto (line 114)
<https://reviews.apache.org/r/43022/#comment178625>
Why Docker specific here? It can be used by, for example, appc as well, right? Just mention that it's the working directory for the container.
include/mesos/slave/isolator.proto (lines 118 - 122)
<https://reviews.apache.org/r/43022/#comment178629>
Let's not change the numbering here.
- Jie Yu
On Feb. 2, 2016, 5:18 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43022/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2016, 5:18 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-4517
> https://issues.apache.org/jira/browse/MESOS-4517
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added protobuf fields for docker runtime isolator.
>
>
> Diffs
> -----
>
> include/mesos/slave/isolator.proto 8b7c54afc4467084b5d22387e55689d06078b504
>
> Diff: https://reviews.apache.org/r/43022/diff/
>
>
> Testing
> -------
>
> make check (ubuntu14.04 + clang-3.6)
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 43022: Added protobuf fields for docker runtime
isolator.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43022/
-----------------------------------------------------------
(Updated Feb. 3, 2016, 12:41 p.m.)
Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
Bugs: MESOS-4517
https://issues.apache.org/jira/browse/MESOS-4517
Repository: mesos
Description
-------
Added protobuf fields for docker runtime isolator.
Diffs (updated)
-----
include/mesos/slave/isolator.proto 8b7c54afc4467084b5d22387e55689d06078b504
Diff: https://reviews.apache.org/r/43022/diff/
Testing
-------
make check (ubuntu14.04 + clang-3.6)
Thanks,
Gilbert Song
Re: Review Request 43022: Added protobuf fields for docker runtime
isolator.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43022/#review117528
-----------------------------------------------------------
include/mesos/slave/isolator.proto (line 115)
<https://reviews.apache.org/r/43022/#comment178725>
Let's use working_directory here.
- Jie Yu
On Feb. 2, 2016, 5:18 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43022/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2016, 5:18 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-4517
> https://issues.apache.org/jira/browse/MESOS-4517
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added protobuf fields for docker runtime isolator.
>
>
> Diffs
> -----
>
> include/mesos/slave/isolator.proto 8b7c54afc4467084b5d22387e55689d06078b504
>
> Diff: https://reviews.apache.org/r/43022/diff/
>
>
> Testing
> -------
>
> make check (ubuntu14.04 + clang-3.6)
>
>
> Thanks,
>
> Gilbert Song
>
>