You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by GitBox <gi...@apache.org> on 2019/11/05 16:03:47 UTC

[GitHub] [cordova-eslint] raphinesse commented on a change in pull request #1: chore: added missing package repo & bug field

raphinesse commented on a change in pull request #1: chore: added missing package repo & bug field
URL: https://github.com/apache/cordova-eslint/pull/1#discussion_r342640279
 
 

 ##########
 File path: package.json
 ##########
 @@ -6,6 +6,13 @@
   "scripts": {
     "test": "eslint ."
   },
+  "repository": {
+    "type": "git",
+    "url": "https://github.com/apache/cordova-eslint"
+  },
+  "bugs": {
+    "url": "https://github.com/apache/cordova-eslint/issues"
+  },
 
 Review comment:
   From the [`package.json` docs](https://docs.npmjs.com/files/package.json#bugs):
   > If you want to provide only a url, you can specify the value for “bugs” as a simple string instead of an object.
   
   I would prefer we do that to keep our `package.json` files as concise as possible, i. e.:
   ```json
   "bugs": "https://github.com/apache/cordova-eslint/issues",
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org