You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Sean Schofield <se...@gmail.com> on 2005/02/08 22:07:34 UTC
Re: Another bug in h:selectBooleanCheckbox while embeded in a x:dataTable
Sylvain,
If I understand you correctly, the problem applies to h:/x:dataTable.
Can you provide us a simple example to look at that demonstrates the
problem? Please leave the tabbed panel stuff out of the example in
order to simplify things.
While I am awaiting your example, I have a theory. There are some
tricky issues with components that manage their own children. I
learned this while doing some research for the new tree component I am
working on. In dataTable (and simliar components) you need to make
sure that the submitted values get passed all the way through to the
child components in the appropriate manner.
When I looked at the MyFaces dataTable code last week I had trouble
convincing myself that this was being handled properly in all cases.
I didn't find a bug, I was just not sure of how things worked. It
might be possible that this is your problem. I will try and look at
it some more tonight.
sean
On Tue, 08 Feb 2005 14:25:32 -0400, Sylvain Vieujot <sv...@apache.org> wrote:
> I still have problems with h:selectBooleanCheckbox when they are in a
> h:/x:dataTable.
> Even setting preserveDataModel="true", the submitted value is lost.
> To see the error, make an x:panelTab, with an x:dataTable with
> h:selectBooleanCheckbox.
>
> If you select another tab, and then come back to the initial tab, the
> submitted values are lost.
> But if you have just a h:selectBooleanCheckbox inside a x:panelTabbedPane,
> the submitted value is retained.
> So, I guess this is just an x:dataTable related bug.
>
> As I saw some discussions on that topic, does someone has any clue that
> would help me fix this bug ?
>
> Thanks,
>
> Sylvain.
Re: Another bug in h:selectBooleanCheckbox while embeded in a x:dataTable
Posted by Sean Schofield <se...@gmail.com>.
Sylvain,
I'm interested in learning more about some of the MyFaces components
so this will be an excuse for me to look more closely at the tabbed
panel. I will try to take a look at it tonight when I get home from
work.
sean
ps. I like what I have seen of the HtmlEditor so far (I believe that
is something you are working on right?)
On Tue, 08 Feb 2005 19:00:51 -0400, Sylvain Vieujot <sv...@apache.org> wrote:
> Hello Sean,
>
> I just committed an example in the examples webapp, tabbedPane.jsp, third
> tab.
> I added it in the tabbed pane, as it's the easiest way to recreate the
> problem. If you go through the apply values phase, then you don't have the
> bug.
>
> I also looked into the HtmlDataTableHack. I couldn't spot any problem, but
> I still think the problem might be around there.
>
> Thanks for your thoughts/fixes.
>
> Sylvain.
>
>
> On Tue, 2005-02-08 at 16:07 -0500, Sean Schofield wrote:
> Sylvain, If I understand you correctly, the problem applies to
> h:/x:dataTable. Can you provide us a simple example to look at that
> demonstrates the problem? Please leave the tabbed panel stuff out of the
> example in order to simplify things. While I am awaiting your example, I
> have a theory. There are some tricky issues with components that manage
> their own children. I learned this while doing some research for the new
> tree component I am working on. In dataTable (and simliar components) you
> need to make sure that the submitted values get passed all the way through
> to the child components in the appropriate manner. When I looked at the
> MyFaces dataTable code last week I had trouble convincing myself that this
> was being handled properly in all cases. I didn't find a bug, I was just not
> sure of how things worked. It might be possible that this is your problem. I
> will try and look at it some more tonight. sean On Tue, 08 Feb 2005 14:25:32
> -0400, Sylvain Vieujot <sv...@apache.org> wrote: > I still have problems
> with h:selectBooleanCheckbox when they are in a > h:/x:dataTable. > Even
> setting preserveDataModel="true", the submitted value is lost. > To see the
> error, make an x:panelTab, with an x:dataTable with >
> h:selectBooleanCheckbox. > > If you select another tab, and then come back
> to the initial tab, the > submitted values are lost. > But if you have just
> a h:selectBooleanCheckbox inside a x:panelTabbedPane, > the submitted value
> is retained. > So, I guess this is just an x:dataTable related bug. > > As I
> saw some discussions on that topic, does someone has any clue that > would
> help me fix this bug ? > > Thanks, > > Sylvain.
Re: Another bug in h:selectBooleanCheckbox while embeded in a
x:dataTable
Posted by Sylvain Vieujot <sv...@apache.org>.
Hello Sean,
I just committed an example in the examples webapp, tabbedPane.jsp,
third tab.
I added it in the tabbed pane, as it's the easiest way to recreate the
problem. If you go through the apply values phase, then you don't have
the bug.
I also looked into the HtmlDataTableHack. I couldn't spot any problem,
but I still think the problem might be around there.
Thanks for your thoughts/fixes.
Sylvain.
On Tue, 2005-02-08 at 16:07 -0500, Sean Schofield wrote:
> Sylvain,
>
> If I understand you correctly, the problem applies to h:/x:dataTable.
> Can you provide us a simple example to look at that demonstrates the
> problem? Please leave the tabbed panel stuff out of the example in
> order to simplify things.
>
> While I am awaiting your example, I have a theory. There are some
> tricky issues with components that manage their own children. I
> learned this while doing some research for the new tree component I am
> working on. In dataTable (and simliar components) you need to make
> sure that the submitted values get passed all the way through to the
> child components in the appropriate manner.
>
> When I looked at the MyFaces dataTable code last week I had trouble
> convincing myself that this was being handled properly in all cases.
> I didn't find a bug, I was just not sure of how things worked. It
> might be possible that this is your problem. I will try and look at
> it some more tonight.
>
> sean
>
> On Tue, 08 Feb 2005 14:25:32 -0400, Sylvain Vieujot <sv...@apache.org> wrote:
> > I still have problems with h:selectBooleanCheckbox when they are in a
> > h:/x:dataTable.
> > Even setting preserveDataModel="true", the submitted value is lost.
> > To see the error, make an x:panelTab, with an x:dataTable with
> > h:selectBooleanCheckbox.
> >
> > If you select another tab, and then come back to the initial tab, the
> > submitted values are lost.
> > But if you have just a h:selectBooleanCheckbox inside a x:panelTabbedPane,
> > the submitted value is retained.
> > So, I guess this is just an x:dataTable related bug.
> >
> > As I saw some discussions on that topic, does someone has any clue that
> > would help me fix this bug ?
> >
> > Thanks,
> >
> > Sylvain.