You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/05/10 02:50:11 UTC
Review Request 21294: Only serve thrift over HTTP.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21294/
-----------------------------------------------------------
Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Maxim Khutornenko.
Bugs: AURORA-342
https://issues.apache.org/jira/browse/AURORA-342
Repository: aurora
Description
-------
Only serve thrift over HTTP.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java bf3d7a36a575bb9d64f4dd851c63fbebda1e61b8
src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java c14d5c2d059e8970b2f232b7a2a0958ba8cffcb8
src/main/java/org/apache/aurora/scheduler/thrift/ThriftServer.java 5b55e941d8efb17fd8740614d8f67cea3931e2c5
src/main/java/org/apache/aurora/scheduler/thrift/ThriftServerLauncher.java bb93be365cfe4f85433e6055290f39723735bd70
src/main/python/apache/aurora/client/api/scheduler_client.py b298d8f310b9e977d74c35a064554bc6d5ee563c
src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java ddbb02560bb8fb94dafe26c1a66c767e9a3a863b
src/test/python/apache/aurora/client/api/test_scheduler_client.py 2736d67e8c47c3ec8d32336aee9fd8cdf3eabc6d
src/test/python/apache/aurora/client/cli/BUILD c0492cc41c5e253fb3a38e347081fe9ef68f3426
src/test/resources/org/apache/aurora/scheduler/app/AuroraTestKeyStore 1157471621099e296fef156dd49569cd9f47e3c1
Diff: https://reviews.apache.org/r/21294/diff/
Testing
-------
I also fixed a bad BUILD reference that was causing python tests to fail.
vagrant up
bash examples/vagrant/test_tutorial.sh
bash build-support/jenkins/build.sh
Thanks,
Bill Farner
Re: Review Request 21294: Only serve thrift over HTTP.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21294/#review43393
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On May 9, 2014, 5:50 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21294/
> -----------------------------------------------------------
>
> (Updated May 9, 2014, 5:50 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Maxim Khutornenko.
>
>
> Bugs: AURORA-342
> https://issues.apache.org/jira/browse/AURORA-342
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Only serve thrift over HTTP.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java bf3d7a36a575bb9d64f4dd851c63fbebda1e61b8
> src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java c14d5c2d059e8970b2f232b7a2a0958ba8cffcb8
> src/main/java/org/apache/aurora/scheduler/thrift/ThriftServer.java 5b55e941d8efb17fd8740614d8f67cea3931e2c5
> src/main/java/org/apache/aurora/scheduler/thrift/ThriftServerLauncher.java bb93be365cfe4f85433e6055290f39723735bd70
> src/main/python/apache/aurora/client/api/scheduler_client.py b298d8f310b9e977d74c35a064554bc6d5ee563c
> src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java ddbb02560bb8fb94dafe26c1a66c767e9a3a863b
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 2736d67e8c47c3ec8d32336aee9fd8cdf3eabc6d
> src/test/python/apache/aurora/client/cli/BUILD c0492cc41c5e253fb3a38e347081fe9ef68f3426
> src/test/resources/org/apache/aurora/scheduler/app/AuroraTestKeyStore 1157471621099e296fef156dd49569cd9f47e3c1
>
> Diff: https://reviews.apache.org/r/21294/diff/
>
>
> Testing
> -------
>
> I also fixed a bad BUILD reference that was causing python tests to fail.
>
> vagrant up
> bash examples/vagrant/test_tutorial.sh
>
>
> bash build-support/jenkins/build.sh
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 21294: Only serve thrift over HTTP.
Posted by Bill Farner <wf...@apache.org>.
> On May 12, 2014, 10:17 p.m., Kevin Sweeney wrote:
> > src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java, line 241
> > <https://reviews.apache.org/r/21294/diff/1/?file=578006#file578006line241>
> >
> > Runnable?
I explored that, but Runnable has the downside of declaring no checked exceptions, so i would have to add more code to try/catch/rethrow MonitorException.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21294/#review42757
-----------------------------------------------------------
On May 10, 2014, 12:50 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21294/
> -----------------------------------------------------------
>
> (Updated May 10, 2014, 12:50 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Maxim Khutornenko.
>
>
> Bugs: AURORA-342
> https://issues.apache.org/jira/browse/AURORA-342
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Only serve thrift over HTTP.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java bf3d7a36a575bb9d64f4dd851c63fbebda1e61b8
> src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java c14d5c2d059e8970b2f232b7a2a0958ba8cffcb8
> src/main/java/org/apache/aurora/scheduler/thrift/ThriftServer.java 5b55e941d8efb17fd8740614d8f67cea3931e2c5
> src/main/java/org/apache/aurora/scheduler/thrift/ThriftServerLauncher.java bb93be365cfe4f85433e6055290f39723735bd70
> src/main/python/apache/aurora/client/api/scheduler_client.py b298d8f310b9e977d74c35a064554bc6d5ee563c
> src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java ddbb02560bb8fb94dafe26c1a66c767e9a3a863b
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 2736d67e8c47c3ec8d32336aee9fd8cdf3eabc6d
> src/test/python/apache/aurora/client/cli/BUILD c0492cc41c5e253fb3a38e347081fe9ef68f3426
> src/test/resources/org/apache/aurora/scheduler/app/AuroraTestKeyStore 1157471621099e296fef156dd49569cd9f47e3c1
>
> Diff: https://reviews.apache.org/r/21294/diff/
>
>
> Testing
> -------
>
> I also fixed a bad BUILD reference that was causing python tests to fail.
>
> vagrant up
> bash examples/vagrant/test_tutorial.sh
>
>
> bash build-support/jenkins/build.sh
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 21294: Only serve thrift over HTTP.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21294/#review42757
-----------------------------------------------------------
src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java
<https://reviews.apache.org/r/21294/#comment76638>
Runnable?
- Kevin Sweeney
On May 9, 2014, 5:50 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21294/
> -----------------------------------------------------------
>
> (Updated May 9, 2014, 5:50 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Maxim Khutornenko.
>
>
> Bugs: AURORA-342
> https://issues.apache.org/jira/browse/AURORA-342
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Only serve thrift over HTTP.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java bf3d7a36a575bb9d64f4dd851c63fbebda1e61b8
> src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java c14d5c2d059e8970b2f232b7a2a0958ba8cffcb8
> src/main/java/org/apache/aurora/scheduler/thrift/ThriftServer.java 5b55e941d8efb17fd8740614d8f67cea3931e2c5
> src/main/java/org/apache/aurora/scheduler/thrift/ThriftServerLauncher.java bb93be365cfe4f85433e6055290f39723735bd70
> src/main/python/apache/aurora/client/api/scheduler_client.py b298d8f310b9e977d74c35a064554bc6d5ee563c
> src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java ddbb02560bb8fb94dafe26c1a66c767e9a3a863b
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 2736d67e8c47c3ec8d32336aee9fd8cdf3eabc6d
> src/test/python/apache/aurora/client/cli/BUILD c0492cc41c5e253fb3a38e347081fe9ef68f3426
> src/test/resources/org/apache/aurora/scheduler/app/AuroraTestKeyStore 1157471621099e296fef156dd49569cd9f47e3c1
>
> Diff: https://reviews.apache.org/r/21294/diff/
>
>
> Testing
> -------
>
> I also fixed a bad BUILD reference that was causing python tests to fail.
>
> vagrant up
> bash examples/vagrant/test_tutorial.sh
>
>
> bash build-support/jenkins/build.sh
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 21294: Only serve thrift over HTTP.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21294/#review42703
-----------------------------------------------------------
Ship it!
src/test/python/apache/aurora/client/cli/BUILD
<https://reviews.apache.org/r/21294/#comment76518>
This is already fixed on master.
- Maxim Khutornenko
On May 10, 2014, 12:50 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21294/
> -----------------------------------------------------------
>
> (Updated May 10, 2014, 12:50 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Maxim Khutornenko.
>
>
> Bugs: AURORA-342
> https://issues.apache.org/jira/browse/AURORA-342
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Only serve thrift over HTTP.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java bf3d7a36a575bb9d64f4dd851c63fbebda1e61b8
> src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java c14d5c2d059e8970b2f232b7a2a0958ba8cffcb8
> src/main/java/org/apache/aurora/scheduler/thrift/ThriftServer.java 5b55e941d8efb17fd8740614d8f67cea3931e2c5
> src/main/java/org/apache/aurora/scheduler/thrift/ThriftServerLauncher.java bb93be365cfe4f85433e6055290f39723735bd70
> src/main/python/apache/aurora/client/api/scheduler_client.py b298d8f310b9e977d74c35a064554bc6d5ee563c
> src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java ddbb02560bb8fb94dafe26c1a66c767e9a3a863b
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 2736d67e8c47c3ec8d32336aee9fd8cdf3eabc6d
> src/test/python/apache/aurora/client/cli/BUILD c0492cc41c5e253fb3a38e347081fe9ef68f3426
> src/test/resources/org/apache/aurora/scheduler/app/AuroraTestKeyStore 1157471621099e296fef156dd49569cd9f47e3c1
>
> Diff: https://reviews.apache.org/r/21294/diff/
>
>
> Testing
> -------
>
> I also fixed a bad BUILD reference that was causing python tests to fail.
>
> vagrant up
> bash examples/vagrant/test_tutorial.sh
>
>
> bash build-support/jenkins/build.sh
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 21294: Only serve thrift over HTTP.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21294/
-----------------------------------------------------------
(Updated May 19, 2014, 6:54 p.m.)
Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Maxim Khutornenko.
Changes
-------
Rebased on master.
Bugs: AURORA-342
https://issues.apache.org/jira/browse/AURORA-342
Repository: aurora
Description
-------
Only serve thrift over HTTP.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java da6f5e5cfe716ca74bceab2ef5b52ec468d73ea2
src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java fc5610ec4483bf236da39cb31c0756934b6d264f
src/main/java/org/apache/aurora/scheduler/thrift/ThriftServer.java 5b55e941d8efb17fd8740614d8f67cea3931e2c5
src/main/java/org/apache/aurora/scheduler/thrift/ThriftServerLauncher.java bb93be365cfe4f85433e6055290f39723735bd70
src/main/python/apache/aurora/client/api/scheduler_client.py ff5d2bc52af75ff2d2eee2d9b72c8d9a0df12581
src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java df5a5da120b754f7da5122feed99039c6ce7b613
src/test/python/apache/aurora/client/api/test_scheduler_client.py 399d4c614dda93ae0e7d8f38a02379bc0f42e4af
src/test/resources/org/apache/aurora/scheduler/app/AuroraTestKeyStore 1157471621099e296fef156dd49569cd9f47e3c1
Diff: https://reviews.apache.org/r/21294/diff/
Testing
-------
I also fixed a bad BUILD reference that was causing python tests to fail.
vagrant up
bash examples/vagrant/test_tutorial.sh
bash build-support/jenkins/build.sh
Thanks,
Bill Farner
Re: Review Request 21294: Only serve thrift over HTTP.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21294/#review43002
-----------------------------------------------------------
Ship it!
Ship It!
- Mark Chu-Carroll
On May 9, 2014, 8:50 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21294/
> -----------------------------------------------------------
>
> (Updated May 9, 2014, 8:50 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Maxim Khutornenko.
>
>
> Bugs: AURORA-342
> https://issues.apache.org/jira/browse/AURORA-342
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Only serve thrift over HTTP.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java bf3d7a36a575bb9d64f4dd851c63fbebda1e61b8
> src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java c14d5c2d059e8970b2f232b7a2a0958ba8cffcb8
> src/main/java/org/apache/aurora/scheduler/thrift/ThriftServer.java 5b55e941d8efb17fd8740614d8f67cea3931e2c5
> src/main/java/org/apache/aurora/scheduler/thrift/ThriftServerLauncher.java bb93be365cfe4f85433e6055290f39723735bd70
> src/main/python/apache/aurora/client/api/scheduler_client.py b298d8f310b9e977d74c35a064554bc6d5ee563c
> src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java ddbb02560bb8fb94dafe26c1a66c767e9a3a863b
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 2736d67e8c47c3ec8d32336aee9fd8cdf3eabc6d
> src/test/python/apache/aurora/client/cli/BUILD c0492cc41c5e253fb3a38e347081fe9ef68f3426
> src/test/resources/org/apache/aurora/scheduler/app/AuroraTestKeyStore 1157471621099e296fef156dd49569cd9f47e3c1
>
> Diff: https://reviews.apache.org/r/21294/diff/
>
>
> Testing
> -------
>
> I also fixed a bad BUILD reference that was causing python tests to fail.
>
> vagrant up
> bash examples/vagrant/test_tutorial.sh
>
>
> bash build-support/jenkins/build.sh
>
>
> Thanks,
>
> Bill Farner
>
>