You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Steve Rowe (JIRA)" <ji...@apache.org> on 2016/12/07 17:38:58 UTC
[jira] [Commented] (LUCENE-7564) AnalyzingInfixSuggester should
close its IndexWriter by default at the end of build()
[ https://issues.apache.org/jira/browse/LUCENE-7564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15729359#comment-15729359 ]
Steve Rowe commented on LUCENE-7564:
------------------------------------
Another non-reproducing seed, this one on branch_6x, from Policeman Jenkins [https://jenkins.thetaphi.de/job/Lucene-Solr-6.x-MacOSX/558/]:
{noformat}
Checking out Revision 3ce1ec3bff3b1ce294569ea3e48d3a2dc6aafb62 (refs/remotes/origin/branch_6x)
[...]
[junit4] Suite: org.apache.lucene.search.suggest.analyzing.AnalyzingInfixSuggesterTest
[junit4] 2> dec. 06, 2016 12:18:03 AM com.carrotsearch.randomizedtesting.RandomizedRunner$QueueUncaughtExceptionsHandler uncaughtException
[junit4] 2> WARNING: Uncaught exception in thread: Thread[Thread-1,5,TGRP-AnalyzingInfixSuggesterTest]
[junit4] 2> org.apache.lucene.store.AlreadyClosedException: this ReferenceManager is closed
[junit4] 2> at __randomizedtesting.SeedInfo.seed([570DDDB64D691936]:0)
[junit4] 2> at org.apache.lucene.search.ReferenceManager.acquire(ReferenceManager.java:98)
[junit4] 2> at org.apache.lucene.search.suggest.analyzing.AnalyzingInfixSuggester.lookup(AnalyzingInfixSuggester.java:645)
[junit4] 2> at org.apache.lucene.search.suggest.analyzing.AnalyzingInfixSuggester.lookup(AnalyzingInfixSuggester.java:457)
[junit4] 2> at org.apache.lucene.search.suggest.analyzing.AnalyzingInfixSuggesterTest$LookupThread.run(AnalyzingInfixSuggesterTest.java:533)
[junit4] 2>
[junit4] 2> NOTE: reproduce with: ant test -Dtestcase=AnalyzingInfixSuggesterTest -Dtests.method=testRandomNRT -Dtests.seed=570DDDB64D691936 -Dtests.slow=true -Dtests.locale=da-DK -Dtests.timezone=NZ-CHAT -Dtests.asserts=true -Dtests.file.encoding=ISO-8859-1
[junit4] ERROR 22.4s J0 | AnalyzingInfixSuggesterTest.testRandomNRT <<<
[junit4] > Throwable #1: com.carrotsearch.randomizedtesting.UncaughtExceptionError: Captured an uncaught exception in thread: Thread[id=29, name=Thread-1, state=RUNNABLE, group=TGRP-AnalyzingInfixSuggesterTest]
[junit4] > at __randomizedtesting.SeedInfo.seed([570DDDB64D691936:F323D30B15B6C58A]:0)
[junit4] > Caused by: org.apache.lucene.store.AlreadyClosedException: this ReferenceManager is closed
[junit4] > at __randomizedtesting.SeedInfo.seed([570DDDB64D691936]:0)
[junit4] > at org.apache.lucene.search.ReferenceManager.acquire(ReferenceManager.java:98)
[junit4] > at org.apache.lucene.search.suggest.analyzing.AnalyzingInfixSuggester.lookup(AnalyzingInfixSuggester.java:645)
[junit4] > at org.apache.lucene.search.suggest.analyzing.AnalyzingInfixSuggester.lookup(AnalyzingInfixSuggester.java:457)
[junit4] > at org.apache.lucene.search.suggest.analyzing.AnalyzingInfixSuggesterTest$LookupThread.run(AnalyzingInfixSuggesterTest.java:533)
[junit4] 2> NOTE: test params are: codec=CheapBastard, sim=RandomSimilarity(queryNorm=true,coord=crazy): {}, locale=da-DK, timezone=NZ-CHAT
[junit4] 2> NOTE: Mac OS X 10.11.6 x86_64/Oracle Corporation 1.8.0_102 (64-bit)/cpus=3,threads=1,free=172227408,total=503316480
[junit4] 2> NOTE: All tests run in this JVM: [FileDictionaryTest, TestWordBreakSpellChecker, DocumentDictionaryTest, TestLevenshteinDistance, TestFuzzyCompletionQuery, TestContextQuery, BytesRefSortersTest, TestJaroWinklerDistance, AnalyzingInfixSuggesterTest]
[junit4] Completed [31/32 (1!)] on J0 in 24.01s, 22 tests, 1 error <<< FAILURES!
{noformat}
bq. I'm beasting the test now with the above seed to see if I can get it to fail.
Previous beasting attempts didn't trigger any failures. I'm beasting for 500 iterations on my Jenkins box now.
> AnalyzingInfixSuggester should close its IndexWriter by default at the end of build()
> -------------------------------------------------------------------------------------
>
> Key: LUCENE-7564
> URL: https://issues.apache.org/jira/browse/LUCENE-7564
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Steve Rowe
> Assignee: Steve Rowe
> Fix For: master (7.0), 6.4
>
> Attachments: LUCENE-7564.patch, LUCENE-7564.patch
>
>
> From SOLR-6246, where AnalyzingInfixSuggester's write lock on its index is causing trouble when reloading a Solr core:
> [~gsingers] wrote:
> bq. One suggestion that might minimize the impact: close the writer after build
> [~varunthacker] wrote:
> {quote}
> This is what I am thinking -
> Create a Lucene issue in which {{AnalyzingInfixSuggester#build}} closes the writer by default at the end.
> The {{add}} and {{update}} methods call {{ensureOpen}} and those who do frequent real time updates directly via lucene won't see any slowdowns.
> [~mikemccand] - Would this approach have any major drawback from Lucene's perspective? Else I can go ahead an tackle this in a Lucene issue
> {quote}
> [~mikemccand] wrote:
> bq. Fixing {{AnalyzingInfixSuggester}} to close the writer at the end of build seems reasonable?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org