You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/11/20 08:57:32 UTC

[GitHub] [ignite] nizhikov commented on pull request #8252: IGNITE-13450 Add event fired before query execution

nizhikov commented on pull request #8252:
URL: https://github.com/apache/ignite/pull/8252#issuecomment-731036243


   Hello, @SomeFire @timoninmaxim 
   
   I looked at the PR.
   Please, resolve comments.
   
   We have `RunningQueryManager#register` method that tracks the running query, already.
   Looks like `SqlQueryExecutionEvents` should be fired in the same places as the execution of this method.
   But for not we have different usages of the methods.
   Is it intentional? What is the rational behind it?
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org