[GitHub] [hbase] saintstack commented on a change in pull request #2283: HBASE-24885 STUCK RIT by hbck2 assigns

[GitBox <gi...@apache.org>]

saintstack commented on a change in pull request #2283:
URL: https://github.com/apache/hbase/pull/2283#discussion_r474781380



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStateNode.java
##########
@@ -190,10 +190,11 @@ public ServerName setRegionLocation(final ServerName serverName) {
     return lastRegionLocation;
   }
 
-  public void setProcedure(TransitRegionStateProcedure proc) {
+  public TransitRegionStateProcedure setProcedure(TransitRegionStateProcedure proc) {

Review comment:
       Thanks for review.
   
   Change was to make the method adhere to fluent style https://en.wikipedia.org/wiki/Fluent_interface
   
   I had:
   ```
   setProcedure(p);
   return p;
   ```
   
   and wanted to do below instead:
   
   `return setProcedure(p);`
   
   Can undo it if you'd prefer.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org