You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/03/02 07:13:19 UTC
[GitHub] [apisix] Horus-K opened a new issue #6486: feat: route 变量匹配增加不区分大小写功能
Horus-K opened a new issue #6486:
URL: https://github.com/apache/apisix/issues/6486
### Issue description
if ($arg_appid = "1"){
set XXXX;
}
nginx中对于判断arg变量本身不区分大小写 但apisix区分大小写，是否可以支持变量本身大小写
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Belyenochi commented on issue #6486: feat: route matching variables support case insensitivity
Posted by GitBox <gi...@apache.org>.
Belyenochi commented on issue #6486:
URL: https://github.com/apache/apisix/issues/6486#issuecomment-1056680336
> confirmed, I think it's a good proposition. @Horus-K
@shuaijinchao Does the question want apisix to support case insensitivity,if so can it be assigned to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on issue #6486: feat: route matching variables support case insensitivity
Posted by GitBox <gi...@apache.org>.
shuaijinchao commented on issue #6486:
URL: https://github.com/apache/apisix/issues/6486#issuecomment-1056892271
> @shuaijinchao Sorry, didn't have time to fix it
OK @Belyenochi do you want to do this PR? once confirmed, I can assign it to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Horus-K commented on issue #6486: feat: route matching variables support case insensitivity
Posted by GitBox <gi...@apache.org>.
Horus-K commented on issue #6486:
URL: https://github.com/apache/apisix/issues/6486#issuecomment-1058938782
#6513 A new problem has appeared, please help @spacewander
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Horus-K commented on issue #6486: feat: route matching variables support case insensitivity
Posted by GitBox <gi...@apache.org>.
Horus-K commented on issue #6486:
URL: https://github.com/apache/apisix/issues/6486#issuecomment-1056840059
@shuaijinchao Sorry, didn't have time to fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Horus-K commented on issue #6486: feat: route matching variables support case insensitivity
Posted by GitBox <gi...@apache.org>.
Horus-K commented on issue #6486:
URL: https://github.com/apache/apisix/issues/6486#issuecomment-1057918144
Is it possible to make case sensitivity an option？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Horus-K commented on issue #6486: feat: route matching variables support case insensitivity
Posted by GitBox <gi...@apache.org>.
Horus-K commented on issue #6486:
URL: https://github.com/apache/apisix/issues/6486#issuecomment-1057918744
Is it possible to make case sensitivity an option @spacewander
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Belyenochi commented on issue #6486: feat: route matching variables support case insensitivity
Posted by GitBox <gi...@apache.org>.
Belyenochi commented on issue #6486:
URL: https://github.com/apache/apisix/issues/6486#issuecomment-1056908919
> > @shuaijinchao Sorry, didn't have time to fix it
>
> OK @Belyenochi do you want to do this PR? once confirmed, I can assign it to you.
h1 @shuaijinchao, pls assign it to me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander closed issue #6486: feat: route matching variables support case insensitivity
Posted by GitBox <gi...@apache.org>.
spacewander closed issue #6486:
URL: https://github.com/apache/apisix/issues/6486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #6486: feat: route matching variables support case insensitivity
Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #6486:
URL: https://github.com/apache/apisix/issues/6486#issuecomment-1057942552
No. We don't have place to put the option in the expression. And such option disobeys the HTTP standard. Also it makes the user can't distinguish the correct argument from the wrong one. For example, we may match `useRid` as user id while the upstream treats `userID` as the real user ID, which may bring additional security risk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on issue #6486: feat: route matching variables support case insensitivity
Posted by GitBox <gi...@apache.org>.
shuaijinchao commented on issue #6486:
URL: https://github.com/apache/apisix/issues/6486#issuecomment-1056605660
confirm, I think it's a good proposition. @Horus-K
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #6486: feat: route matching variables support case insensitivity
Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #6486:
URL: https://github.com/apache/apisix/issues/6486#issuecomment-1057900813
@Belyenochi @shuaijinchao
I am afraid arg_xxx should be case-sensitive.
See https://stackoverflow.com/a/24700171.
> So the query part of the URI as defined by the spec for the HTTP scheme is case-sensitive.
It is a limitation of Nginx that it handles all the variables in case-insensitive way. In fact, OpenResty's `get_uri_args` handles it correctly:
```
server {
listen 9981;
location / {
content_by_lua_block {
local cjson = require("cjson")
ngx.say(cjson.encode(ngx.req.get_uri_args()))
}
}
}
```
with `curl '127.0.0.1:9981?a=2&A=1'`, it gets `{"A":"1","a":"2"}`.
It would be good if we can follow the standard and get rid of Nginx's weird behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on issue #6486: feat: route matching variables support case insensitivity
Posted by GitBox <gi...@apache.org>.
shuaijinchao commented on issue #6486:
URL: https://github.com/apache/apisix/issues/6486#issuecomment-1056833062
thx~ @Belyenochi, yes, I think it should be done. I would like to know first if @Horus-K , as the person who found this issue, is willing to fix it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] shuaijinchao edited a comment on issue #6486: feat: route matching variables support case insensitivity
Posted by GitBox <gi...@apache.org>.
shuaijinchao edited a comment on issue #6486:
URL: https://github.com/apache/apisix/issues/6486#issuecomment-1056605660
confirmed, I think it's a good proposition. @Horus-K
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Horus-K removed a comment on issue #6486: feat: route matching variables support case insensitivity
Posted by GitBox <gi...@apache.org>.
Horus-K removed a comment on issue #6486:
URL: https://github.com/apache/apisix/issues/6486#issuecomment-1057918144
Is it possible to make case sensitivity an option？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org