You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/06/04 19:59:22 UTC
[GitHub] [commons-compress] XenoAmess opened a new pull request #112: remove `== null` as it is covered by `instance of`
XenoAmess opened a new pull request #112:
URL: https://github.com/apache/commons-compress/pull/112
Or, is it for special optimization strategy?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] bodewig merged pull request #112: remove `== null` as it is covered by `instance of`
Posted by GitBox <gi...@apache.org>.
bodewig merged pull request #112:
URL: https://github.com/apache/commons-compress/pull/112
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] PeterAlfredLee commented on pull request #112: remove `== null` as it is covered by `instance of`
Posted by GitBox <gi...@apache.org>.
PeterAlfredLee commented on pull request #112:
URL: https://github.com/apache/commons-compress/pull/112#issuecomment-639204455
Not sure if this is caused by Sonarqube or some other scans. From my view the null check is not needed here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] PeterAlfredLee commented on pull request #112: remove `== null` as it is covered by `instance of`
Posted by GitBox <gi...@apache.org>.
PeterAlfredLee commented on pull request #112:
URL: https://github.com/apache/commons-compress/pull/112#issuecomment-640316012
> are you talking about the decreased coverage
Nope, I was just wondering if the null check here is caused by some type of static analysis like FindBugs or Sonarqube. This PR looks good to me - if it's not because of some static analysis tool.
> This happens because the builds on different JDKs end with slightly different results and so the coverage fluctuates a bit depending on which JDK's build finishes first.
So that's the reason why the coverage varies when no code is changed. Thank you for your explanation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] bodewig commented on pull request #112: remove `== null` as it is covered by `instance of`
Posted by GitBox <gi...@apache.org>.
bodewig commented on pull request #112:
URL: https://github.com/apache/commons-compress/pull/112#issuecomment-640354810
thanks @XenoAmess
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] bodewig commented on pull request #112: remove `== null` as it is covered by `instance of`
Posted by GitBox <gi...@apache.org>.
bodewig commented on pull request #112:
URL: https://github.com/apache/commons-compress/pull/112#issuecomment-640194759
@PeterAlfredLee are you talking about the decreased coverage? This happens because the builds on different JDKs end with slightly different results and so the coverage fluctuates a bit depending on which JDK's build finishes first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] coveralls commented on pull request #112: remove `== null` as it is covered by `instance of`
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #112:
URL: https://github.com/apache/commons-compress/pull/112#issuecomment-639086451
[](https://coveralls.io/builds/31246999)
Coverage remained the same at 87.29% when pulling **183816382a376ed22f37204eec6caaa5622a100b on XenoAmess:remove_`==_null`_as_it_is_covered_by_`instance_of`** into **18fb261d0bbbb8cc52483267213e0d2ef4c43de7 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org