You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by twalthr <gi...@git.apache.org> on 2016/04/19 13:49:00 UTC
[GitHub] flink pull request: [FLINK-3086] [table] ExpressionParser does not...
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/1912
[FLINK-3086] [table] ExpressionParser does not support concatenation of suffix operations
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [x] General
- The pull request references the related JIRA issue
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
This PR reworks the Table API `ExpressionParser`. It eliminates inconsistencies, adds more complex tests and ensures that everything from Scala Table API is also support in Java Table API.
Even expressions like `a.abs() + a.abs()` or `((((true) === true) || false).cast(STRING) + 'X ').trim` should not be an issue anymore.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twalthr/flink ExpressionParserRework
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1912.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1912
----
commit 9e331bfc45989bef2de8601410a037738fad2d7e
Author: twalthr <tw...@apache.org>
Date: 2016-04-18T14:28:19Z
[FLINK-3086] [table] ExpressionParser does not support concatenation of suffix operations
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3086] [table] ExpressionParser does not...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1912
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3086] [table] ExpressionParser does not...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1912#issuecomment-214814868
Yes, same here ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3086] [table] ExpressionParser does not...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1912#issuecomment-215047867
Ok, I will merge this ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3086] [table] ExpressionParser does not...
Posted by vasia <gi...@git.apache.org>.
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1912#issuecomment-214762168
I'm not very familiar with the `ExpressionParser`, but I don't see anything suspicious :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3086] [table] ExpressionParser does not...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1912#issuecomment-214332026
@vasia @fhueske any comments on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---