You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/30 20:55:05 UTC
[GitHub] [superset] vermilioncity opened a new issue #15483: Hierarchical filters hang when filters are made parents of one another
vermilioncity opened a new issue #15483:
URL: https://github.com/apache/superset/issues/15483
Suppose you have Filter A and Filter B. You set Filter A to be a hierarchical filter and its parent to be Filter B. Then you set Filter B to be a hierarchical filter and its parent to be Filter A. The app hangs. If you open up the dev console, you will see errors printed out complaining about maximum recursion depth exceeded.
### Expected results
Filters with already assigned relationships should be excluded from the drop down.
### Actual results
All available filters are shown and the app goes into a recursive loop if you fatfinger and select a preexisting child.
#### How to reproduce the bug
1. Create two filters (filter A and B)
2. Set filter A to be hierarchical and parent as Filter B
3. Set Filter B to be hierarchical and parent to be Filter A
4. Watch app hang forever :(
### Environment
- superset version: `superset version`
- python version: `python --version`
- node.js version: `node -v`
### Checklist
- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
Add any other context about the problem here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #15483: Hierarchical filters hang when filters are made parents of one another
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #15483:
URL: https://github.com/apache/superset/issues/15483#issuecomment-871810947
@vermilioncity thanks for reporting. I was able to reproduce.
This case is tricky! We can't really check both filters as hierarchical and parent.
However, ideally there should be two hierarchical filter sets showing on the filter bar with A as parent, B as child & B as parent A as child. And user can switch between 2 groups. But right now, when I create two groups separately, all the filters become children of A... see video
Have you tried using filter sets (behind another feature flag) as an alternative?
https://user-images.githubusercontent.com/67837651/124045932-a4b45b00-d9c5-11eb-87f9-e3aebee078ef.mov
this seems quite hard to fix and it's really an edge case. @villebro wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina closed issue #15483: Hierarchical filters hang when filters are made parents of one another
Posted by GitBox <gi...@apache.org>.
michael-s-molina closed issue #15483:
URL: https://github.com/apache/superset/issues/15483
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org