[jira] [Commented] (CASSANDRA-17069) Refactor normal/preview/IR repair to standardize repair cleanup and error handling of failed RepairJobs

["Marcus Eriksson (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-17069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17441613#comment-17441613 ] 

Marcus Eriksson commented on CASSANDRA-17069:
---------------------------------------------

a few minor nits on the PR, otherwise lgtm, +1

> Refactor normal/preview/IR repair to standardize repair cleanup and error handling of failed RepairJobs
> -------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-17069
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17069
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Consistency/Repair
>            Reporter: David Capwell
>            Assignee: David Capwell
>            Priority: Normal
>             Fix For: 4.x
>
>
> Right now we have 3 different implementations of repair: normal, preview, and incremental (IR); all 3 handle RepairJob failures differently and offer different state cleanup.  To make sure that we consistently handle errors the same way and cleanup, we should move these responsibilities outside of the repair task itself and move these into common APIs and move some logic into the repair coordination its self.
> This work relates with CASSANDRA-15399 as special handling each task makes the work more complex.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org