You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/12/15 00:16:32 UTC

[GitHub] [spark] sunchao opened a new pull request #30769: [SPARK-33653][SQL] DSv2: REFRESH TABLE should recache the table itself

sunchao opened a new pull request #30769:
URL: https://github.com/apache/spark/pull/30769


   This is a backport of #30742 for branch-3.1
   
   ### What changes were proposed in this pull request?
   
   This changes DSv2 refresh table semantics to also recache the target table itself.
   
   ### Why are the changes needed?
   
   Currently "REFRESH TABLE" in DSv2 only invalidate all caches referencing the table. With #30403 merged which adds support for caching a DSv2 table, we should also recache the target table itself to make the behavior consistent with DSv1.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes, now refreshing table in DSv2 also recache the target table itself.
   ### How was this patch tested?
   
   Added coverage of this new behavior in the existing UT for v2 refresh table command.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #30769: [SPARK-33653][SQL][3.1] DSv2: REFRESH TABLE should recache the table itself

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30769:
URL: https://github.com/apache/spark/pull/30769#issuecomment-744873766


   **[Test build #132784 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132784/testReport)** for PR 30769 at commit [`0978ff7`](https://github.com/apache/spark/commit/0978ff733f30adee61e7faaf3d69537c5d1f8cbc).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30769: [SPARK-33653][SQL][3.1] DSv2: REFRESH TABLE should recache the table itself

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30769:
URL: https://github.com/apache/spark/pull/30769#issuecomment-744873766


   **[Test build #132784 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132784/testReport)** for PR 30769 at commit [`0978ff7`](https://github.com/apache/spark/commit/0978ff733f30adee61e7faaf3d69537c5d1f8cbc).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun closed pull request #30769: [SPARK-33653][SQL][3.1] DSv2: REFRESH TABLE should recache the table itself

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #30769:
URL: https://github.com/apache/spark/pull/30769


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30769: [SPARK-33653][SQL][3.1] DSv2: REFRESH TABLE should recache the table itself

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30769:
URL: https://github.com/apache/spark/pull/30769#issuecomment-745054185


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132784/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30769: [SPARK-33653][SQL][3.1] DSv2: REFRESH TABLE should recache the table itself

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30769:
URL: https://github.com/apache/spark/pull/30769#issuecomment-745002067






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30769: [SPARK-33653][SQL][3.1] DSv2: REFRESH TABLE should recache the table itself

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30769:
URL: https://github.com/apache/spark/pull/30769#issuecomment-745046747


   **[Test build #132784 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132784/testReport)** for PR 30769 at commit [`0978ff7`](https://github.com/apache/spark/commit/0978ff733f30adee61e7faaf3d69537c5d1f8cbc).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30769: [SPARK-33653][SQL][3.1] DSv2: REFRESH TABLE should recache the table itself

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30769:
URL: https://github.com/apache/spark/pull/30769#issuecomment-745002067


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37386/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org