You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2022/04/30 17:45:59 UTC
svn commit: r1900430 - /pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/CMapManager.java
Author: tilman
Date: Sat Apr 30 17:45:59 2022
New Revision: 1900430
URL: http://svn.apache.org/viewvc?rev=1900430&view=rev
Log:
PDFBOX-4892: optimize / simplify, as suggested by Valery Bokov
Modified:
pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/CMapManager.java
Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/CMapManager.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/CMapManager.java?rev=1900430&r1=1900429&r2=1900430&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/CMapManager.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/CMapManager.java Sat Apr 30 17:45:59 2022
@@ -21,17 +21,16 @@ import org.apache.fontbox.cmap.CMapParse
import java.io.IOException;
import java.io.InputStream;
-import java.util.Collections;
-import java.util.HashMap;
+
import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
/**
* CMap resource loader and cache.
*/
final class CMapManager
{
- static Map<String, CMap> cMapCache =
- Collections.synchronizedMap(new HashMap<String, CMap>());
+ static private final Map<String, CMap> CMAP_CACHE = new ConcurrentHashMap<String, CMap>();
private CMapManager()
{
@@ -46,7 +45,7 @@ final class CMapManager
*/
public static CMap getPredefinedCMap(String cMapName) throws IOException
{
- CMap cmap = cMapCache.get(cMapName);
+ CMap cmap = CMAP_CACHE.get(cMapName);
if (cmap != null)
{
return cmap;
@@ -55,7 +54,7 @@ final class CMapManager
CMap targetCmap = new CMapParser().parsePredefined(cMapName);
// limit the cache to predefined CMaps
- cMapCache.put(targetCmap.getName(), targetCmap);
+ CMAP_CACHE.put(targetCmap.getName(), targetCmap);
return targetCmap;
}