You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "yoavcloud (via GitHub)" <gi...@apache.org> on 2024/12/16 15:14:25 UTC
[PR] Add the alter table ON COMMIT option to Snowflake [datafusion-sqlparser-rs]
yoavcloud opened a new pull request, #1606:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1606
It doesn't seem like this option is documented. However, Snowflake supports it, and we see such queries "in the wild."
Syntax:
`CREATE TABLE ... ON COMMIT PRESERVE ROWS`
`CREATE TABLE ... ON COMMIT DELETE ROWS`
`CREATE TABLE ... ON COMMIT DROP`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add the alter table ON COMMIT option to Snowflake [datafusion-sqlparser-rs]
Posted by "iffyio (via GitHub)" <gi...@apache.org>.
iffyio commented on code in PR #1606:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1606#discussion_r1887929948
##########
src/parser/mod.rs:
##########
@@ -6226,6 +6215,21 @@ impl<'a> Parser<'a> {
.build())
}
+ pub fn parse_create_table_on_commit(&mut self) -> Result<OnCommit, ParserError> {
Review Comment:
```suggestion
fn parse_create_table_on_commit(&mut self) -> Result<OnCommit, ParserError> {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add the alter table ON COMMIT option to Snowflake [datafusion-sqlparser-rs]
Posted by "iffyio (via GitHub)" <gi...@apache.org>.
iffyio commented on PR #1606:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1606#issuecomment-2547706159
Thanks @yoavcloud!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add the alter table ON COMMIT option to Snowflake [datafusion-sqlparser-rs]
Posted by "yoavcloud (via GitHub)" <gi...@apache.org>.
yoavcloud commented on code in PR #1606:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1606#discussion_r1887948839
##########
src/parser/mod.rs:
##########
@@ -6226,6 +6215,21 @@ impl<'a> Parser<'a> {
.build())
}
+ pub fn parse_create_table_on_commit(&mut self) -> Result<OnCommit, ParserError> {
Review Comment:
I made it pub(crate), it's being used from snowflake.rs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add the alter table ON COMMIT option to Snowflake [datafusion-sqlparser-rs]
Posted by "iffyio (via GitHub)" <gi...@apache.org>.
iffyio commented on code in PR #1606:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1606#discussion_r1888032340
##########
src/parser/mod.rs:
##########
@@ -6226,6 +6215,21 @@ impl<'a> Parser<'a> {
.build())
}
+ pub fn parse_create_table_on_commit(&mut self) -> Result<OnCommit, ParserError> {
Review Comment:
Ah right that sounds good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add the alter table ON COMMIT option to Snowflake [datafusion-sqlparser-rs]
Posted by "iffyio (via GitHub)" <gi...@apache.org>.
iffyio merged PR #1606:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org