[jira] [Reopened] (FLINK-33159) No functional change - Use the variables instead of multiple literals for java and Maven version checks in the pom file

["david radley (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FLINK-33159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

david radley reopened FLINK-33159:
----------------------------------

Re opening - as this change is not changing the versions to check. It is moving to consistently use Maven and Java variables in the pom file. Currently Java version has multiple literals of 1.8 - this proposal is to change to use one variable with value 1.8 that is then used for the other java version references. It introduces Maven variables for the 2 Maven versions  currently referenced in the pom file.

 

 

> No functional change - Use the variables instead of multiple literals for java and Maven version checks in the pom file 
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-33159
>                 URL: https://issues.apache.org/jira/browse/FLINK-33159
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>            Reporter: david radley
>            Priority: Minor
>              Labels: pull-request-available
>
> Use the variables for java and Maven version checks in the pom file.
> In the pom file I notice line
> _<requireJavaVersion>_
>                    _<version>1.8.0</version>_
>  _</requireJavaVersion>_
> This should use the variable like this:
>   \{_}<version>{_}${target.java.version}{_}</version>{_}
> I also see 2 instanced of _<target.java.version>1.8</target.java.version>_
> The second instance should refer to the variable
> also the Maven versions should use variables.
>  
> I will provide a pr for this.
>  
>  
>  
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)