You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by Yonik Seeley <yo...@lucidimagination.com> on 2009/08/13 20:21:45 UTC

Re: [jira] Closed: (SOLR-475) multi-valued faceting via un-inverted field

Why are we moving things from resolved to closed?  It seems unnecessary.

-Yonik
http://www.lucidimagination.com



On Thu, Aug 13, 2009 at 10:20 AM, Grant Ingersoll (JIRA)<ji...@apache.org> wrote:
>
>     [ https://issues.apache.org/jira/browse/SOLR-475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Grant Ingersoll closed SOLR-475.
> --------------------------------
>
>    Assignee: Yonik Seeley
>
>> multi-valued faceting via un-inverted field
>> -------------------------------------------
>>
>>                 Key: SOLR-475
>>                 URL: https://issues.apache.org/jira/browse/SOLR-475
>>             Project: Solr
>>          Issue Type: New Feature
>>            Reporter: Yonik Seeley
>>            Assignee: Yonik Seeley
>>             Fix For: 1.4
>>
>>         Attachments: facet_performance.html, SOLR-475.patch, SOLR-475.patch, UnInvertedField.java, UnInvertedField.java
>>
>>
>> Facet multi-valued fields via a counting method (like the FieldCache method) on an un-inverted representation of the field.  For each doc, look at it's terms and increment a count for that term.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

Re: [jira] Closed: (SOLR-475) multi-valued faceting via un-inverted field

Posted by Mark Miller <ma...@gmail.com>.
Some back discussion:

http://www.lucidimagination.com/search/document/79b65c358374d10/jira_convention_resolved_vs_closed

I've seen people say just resolve (don't close) as well in other 
discussions.

The way we do things, I don't really think it matters either way. JIRA 
is used fairly loosely with Lucene/Solr.

Grant Ingersoll wrote:
> I always thought that was the thing to do.  It was an indication that 
> the solution has been applied and has proven itself to be correct, 
> versus resolved just meaning it was applied and the author thought it 
> was taken care of.
>
>
> On Aug 13, 2009, at 2:21 PM, Yonik Seeley wrote:
>
>> Why are we moving things from resolved to closed?  It seems unnecessary.
>>
>> -Yonik
>> http://www.lucidimagination.com
>>
>>
>>
>> On Thu, Aug 13, 2009 at 10:20 AM, Grant Ingersoll 
>> (JIRA)<ji...@apache.org> wrote:
>>>
>>>     [ 
>>> https://issues.apache.org/jira/browse/SOLR-475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 
>>>
>>>
>>> Grant Ingersoll closed SOLR-475.
>>> --------------------------------
>>>
>>>    Assignee: Yonik Seeley
>>>
>>>> multi-valued faceting via un-inverted field
>>>> -------------------------------------------
>>>>
>>>>                 Key: SOLR-475
>>>>                 URL: https://issues.apache.org/jira/browse/SOLR-475
>>>>             Project: Solr
>>>>          Issue Type: New Feature
>>>>            Reporter: Yonik Seeley
>>>>            Assignee: Yonik Seeley
>>>>             Fix For: 1.4
>>>>
>>>>         Attachments: facet_performance.html, SOLR-475.patch, 
>>>> SOLR-475.patch, UnInvertedField.java, UnInvertedField.java
>>>>
>>>>
>>>> Facet multi-valued fields via a counting method (like the 
>>>> FieldCache method) on an un-inverted representation of the field.  
>>>> For each doc, look at it's terms and increment a count for that term.
>>>
>>> -- 
>>> This message is automatically generated by JIRA.
>>> -
>>> You can reply to this email to add a comment to the issue online.
>>>
>>>
>
>


-- 
- Mark

http://www.lucidimagination.com




Re: [jira] Closed: (SOLR-475) multi-valued faceting via un-inverted field

Posted by Mark Miller <ma...@gmail.com>.
Grant Ingersoll wrote:
>
> On Aug 13, 2009, at 7:53 PM, Chris Hostetter wrote:
>>
>> (BTW: when using the "Bulk Update" feature in jira, it's really easy 
>> to do
>> things like "select all issues which are 'resolved' and 'Fix
>> For:1.4'; change them to 'closed'; dont' send an email for each")
>
> Good to know.  I think that is reasonable.  I see a very small benefit 
> in closing (namely, that the issue has aged and has solved the 
> problem), but agree no need to do it one by one.  Makes sense to do at 
> the end before a release in one fell swoop.
>
> -Grant
This step is actually already in the Lucene release wiki procedure:

Final step:

11. Go to JIRA and find all issues that were fixed in the release you 
just made, whose Status is Resolved, and do a bulk change to close all 
of these issues. Uncheck the box that says "send an email for these 
changes".

-- 
- Mark

http://www.lucidimagination.com




Re: [jira] Closed: (SOLR-475) multi-valued faceting via un-inverted field

Posted by Grant Ingersoll <gs...@apache.org>.
On Aug 13, 2009, at 7:53 PM, Chris Hostetter wrote:
>
> (BTW: when using the "Bulk Update" feature in jira, it's really easy  
> to do
> things like "select all issues which are 'resolved' and 'Fix
> For:1.4'; change them to 'closed'; dont' send an email for each")

Good to know.  I think that is reasonable.  I see a very small benefit  
in closing (namely, that the issue has aged and has solved the  
problem), but agree no need to do it one by one.  Makes sense to do at  
the end before a release in one fell swoop.

-Grant

Re: [jira] Closed: (SOLR-475) multi-valued faceting via un-inverted field

Posted by Chris Hostetter <ho...@fucit.org>.
: For our open source development, I don't think the distinction makes
: sense and I'd vote for not bothering with "closed".

Doug's comment in the thread mark linked to has always made a lot of sense 
to me: close when the fix/feature is included in a release.  a resolved 
bug means that it's no longer a problem in the development trunk/branches 
listed in "Fix For", a closed bug means it shouldn't be a problem in 
released versions of those "Fix for" branches.

I thought "HowToRelease" had a post-release item to close out any issues 
that were "resolved" and had a "Fix For" the current release ... but 
aparetnly it does not.

(BTW: when using the "Bulk Update" feature in jira, it's really easy to do 
things like "select all issues which are 'resolved' and 'Fix 
For:1.4'; change them to 'closed'; dont' send an email for each")


-Hoss


Re: [jira] Closed: (SOLR-475) multi-valued faceting via un-inverted field

Posted by Yonik Seeley <yo...@lucidimagination.com>.
On Thu, Aug 13, 2009 at 4:31 PM, Grant Ingersoll<gs...@apache.org> wrote:
> I always thought that was the thing to do.  It was an indication that the
> solution has been applied and has proven itself to be correct, versus
> resolved just meaning it was applied and the author thought it was taken
> care of.

I think that's the distinction that the authors of JIRA meant it to
convey... resolved is a developer checking in a patch to solve a
problem, and closed is when the original person that hit the bug
verifies the fix.  It makes more sense in commercial software.

For our open source development, I don't think the distinction makes
sense and I'd vote for not bothering with "closed".

-Yonik
http://www.lucidimagination.com

Re: [jira] Closed: (SOLR-475) multi-valued faceting via un-inverted field

Posted by Grant Ingersoll <gs...@apache.org>.
I always thought that was the thing to do.  It was an indication that  
the solution has been applied and has proven itself to be correct,  
versus resolved just meaning it was applied and the author thought it  
was taken care of.


On Aug 13, 2009, at 2:21 PM, Yonik Seeley wrote:

> Why are we moving things from resolved to closed?  It seems  
> unnecessary.
>
> -Yonik
> http://www.lucidimagination.com
>
>
>
> On Thu, Aug 13, 2009 at 10:20 AM, Grant Ingersoll (JIRA)<jira@apache.org 
> > wrote:
>>
>>     [ https://issues.apache.org/jira/browse/SOLR-475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel 
>>  ]
>>
>> Grant Ingersoll closed SOLR-475.
>> --------------------------------
>>
>>    Assignee: Yonik Seeley
>>
>>> multi-valued faceting via un-inverted field
>>> -------------------------------------------
>>>
>>>                 Key: SOLR-475
>>>                 URL: https://issues.apache.org/jira/browse/SOLR-475
>>>             Project: Solr
>>>          Issue Type: New Feature
>>>            Reporter: Yonik Seeley
>>>            Assignee: Yonik Seeley
>>>             Fix For: 1.4
>>>
>>>         Attachments: facet_performance.html, SOLR-475.patch,  
>>> SOLR-475.patch, UnInvertedField.java, UnInvertedField.java
>>>
>>>
>>> Facet multi-valued fields via a counting method (like the  
>>> FieldCache method) on an un-inverted representation of the field.   
>>> For each doc, look at it's terms and increment a count for that  
>>> term.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>