You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/02/25 15:26:59 UTC

[GitHub] [activemq-artemis] clebertsuconic edited a comment on pull request #3470: ARTEMIS-3106 - Support for SASL-SCRAM

clebertsuconic edited a comment on pull request #3470:
URL: https://github.com/apache/activemq-artemis/pull/3470#issuecomment-785981638


   can you squash all commits up to now.. it would be easier to review it.
   
   Unless you intend to keep them separated.. but a commit just to fix check style could be squashed... 
   
   
   you could keep commits separated while under review.. but right now I'm finding it difficult to comment on the changes.
   
   
   ```
   git rebase -I HEAD~6
   # use the editor to squash or fix all commits into one.
   git push origin -f <YOUR-BRANCH-NAME>
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org