You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by Adam Katz <an...@khopis.com> on 2010/01/27 00:00:46 UTC
syncing SpamAssassin with Debian downstream
If only I had noticed this before the 3.3.0 release...
There are some patches to the Debian package for 3.2.5 which are
applicable to the trunk. I'm comfortable incorporating some of them
myself, but wanted to double-check on this one:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=491159
The update:
http://svn.apache.org/viewvc?view=revision&revision=903473
I've also added Duncan Findlay's Debian-specific rules (which don't
actually look so Debian-specific to me) to my sandbox to see how
useful they might be to a larger audience. They're marked "nopublish"
until we either get a thumbs-up from Duncan or enough time passes that
we can assume full license compatibility.
To ensure there aren't licensing issues, I've copied Duncan and Noah
Meyerhans (the current Debian packager for SpamAssassin) on this email
as a way of keeping everybody on the same page.
Re: UNS: Re: syncing SpamAssassin with Debian downstream
Posted by Noah Meyerhans <fr...@morgul.net>.
On Tue, Jan 26, 2010 at 04:17:27PM -0800, Duncan Findlay wrote:
> http://svn.debian.org/viewsvn/collab-maint/deb-maint/spamassassin/trunk/debian/patches/
>
> Noah, is there something we can do to make it easier to submit these changes upstream?
No; if I've failed to push them up, it's my own fault. I'll try to be
better about it in the future.
BTW, I don't know how much attention you plan on giving to older
versions of spamassassin at this point, but if you're bored, you're
invited to take a look at Debian bug #562566
(http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=562566)
noah
Re: syncing SpamAssassin with Debian downstream
Posted by Noah Meyerhans <fr...@morgul.net>.
On Tue, Jan 26, 2010 at 04:17:27PM -0800, Duncan Findlay wrote:
> All the patches to the source used in the Debian packaging can be found here:
>
> http://svn.debian.org/viewsvn/collab-maint/deb-maint/spamassassin/trunk/debian/patches/
I updated those patches last night to apply to 3.3.0. Please feel free
to take a look at them. Most of them are corrections for spelling and
pod errors and should be reasonable for you to merge upstream.
noah
Re: syncing SpamAssassin with Debian downstream
Posted by Duncan Findlay <du...@apache.org>.
On Jan 26, 2010, at 3:00 PM, Adam Katz wrote:
> If only I had noticed this before the 3.3.0 release...
>
> There are some patches to the Debian package for 3.2.5 which are
> applicable to the trunk. I'm comfortable incorporating some of them
> myself, but wanted to double-check on this one:
>
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=491159
>
> The update:
> http://svn.apache.org/viewvc?view=revision&revision=903473
All the patches to the source used in the Debian packaging can be found here:
http://svn.debian.org/viewsvn/collab-maint/deb-maint/spamassassin/trunk/debian/patches/
Noah, is there something we can do to make it easier to submit these changes upstream?
> I've also added Duncan Findlay's Debian-specific rules (which don't
> actually look so Debian-specific to me) to my sandbox to see how
> useful they might be to a larger audience. They're marked "nopublish"
> until we either get a thumbs-up from Duncan or enough time passes that
> we can assume full license compatibility.
Yikes, that file is ancient; it probably dates back to when we used nice rules with impunity. I'm a little surprised that nobody ever exploited those rules (or nobody noticed somebody exploiting the rules enough to file a bug report).
As far as license issues: I allow inclusion of all or any part of 65_debian.cf to be licensed under the Apache License in accordance with the CLA I have on file.
> To ensure there aren't licensing issues, I've copied Duncan and Noah
> Meyerhans (the current Debian packager for SpamAssassin) on this email
> as a way of keeping everybody on the same page.
Thanks
Duncan
Re: syncing SpamAssassin with Debian downstream
Posted by Noah Meyerhans <no...@debian.org>.
On Tue, Jan 26, 2010 at 11:14:01PM +0000, Justin Mason wrote:
> the rules in spamassassin/trunk/rulesrc/sandbox/khopesh/65_debian.cf
> seem quite unsafe and easily forged by spammers. please ensure they
> stay "nopublish"! if they were meta rules with ALL_TRUSTED, however,
> they'd be more usable.
Hi Justin. You're right that the rules are pretty unsafe. While I've
never heard of them being abused by spammers, it's likely that this is
only due to Debian's relative obscurity. Combining them with
ALL_TRUSTED is a good idea, and I'll consider this a feature request.
noah
Re: syncing SpamAssassin with Debian downstream
Posted by Justin Mason <jm...@jmason.org>.
the rules in spamassassin/trunk/rulesrc/sandbox/khopesh/65_debian.cf
seem quite unsafe and easily forged by spammers. please ensure they
stay "nopublish"! if they were meta rules with ALL_TRUSTED, however,
they'd be more usable.
--j.
On Tue, Jan 26, 2010 at 23:00, Adam Katz <an...@khopis.com> wrote:
> If only I had noticed this before the 3.3.0 release...
>
> There are some patches to the Debian package for 3.2.5 which are
> applicable to the trunk. I'm comfortable incorporating some of them
> myself, but wanted to double-check on this one:
>
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=491159
>
> The update:
> http://svn.apache.org/viewvc?view=revision&revision=903473
>
> I've also added Duncan Findlay's Debian-specific rules (which don't
> actually look so Debian-specific to me) to my sandbox to see how
> useful they might be to a larger audience. They're marked "nopublish"
> until we either get a thumbs-up from Duncan or enough time passes that
> we can assume full license compatibility.
>
> To ensure there aren't licensing issues, I've copied Duncan and Noah
> Meyerhans (the current Debian packager for SpamAssassin) on this email
> as a way of keeping everybody on the same page.
>
>
--
--j.