[GitHub] [incubator-kvrocks] ShooterIT commented on a diff in pull request #538: PSYNC based on Unique Replication Sequence ID

[GitBox <gi...@apache.org>]

ShooterIT commented on code in PR #538:
URL: https://github.com/apache/incubator-kvrocks/pull/538#discussion_r876913444


##########
src/main.cc:
##########
@@ -324,6 +324,10 @@ int main(int argc, char* argv[]) {
       srv->Stop();
     }
   };
+
+  // Generate new replication id if not a replica
+  if (!srv->IsSlave()) storage.ShiftReplId();
+

Review Comment:
   you are right, i missed this, we set master info in `Server::Start ` instead of loading config file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org