You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "pvillard31 (via GitHub)" <gi...@apache.org> on 2025/11/25 12:50:32 UTC
[PR] NIFI-15253 - Add additionalDetails with Setup instructions for Azure Git DevOps Flow Registry Client [nifi]
pvillard31 opened a new pull request, #10562:
URL: https://github.com/apache/nifi/pull/10562
# Summary
NIFI-15253 - Add additionalDetails with Setup instructions for Azure Git DevOps Flow Registry Client
<img width="500" alt="Screenshot 2025-11-25 at 13 48 24" src="https://github.com/user-attachments/assets/b4521bea-c765-4bcb-b187-299b1e705665" />
<img width="500" alt="Screenshot 2025-11-25 at 13 48 11" src="https://github.com/user-attachments/assets/08d28374-08c2-4bbf-a4f8-2759ccb83c29" />
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `./mvnw clean install -P contrib-check`
- [ ] JDK 21
- [ ] JDK 25
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-15253 - Add additionalDetails with Setup instructions for Azure Git DevOps Flow Registry Client [nifi]
Posted by "mcgilman (via GitHub)" <gi...@apache.org>.
mcgilman commented on code in PR #10562:
URL: https://github.com/apache/nifi/pull/10562#discussion_r2560464259
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/settings/ui/registry-clients/registry-clients.component.spec.ts:
##########
@@ -228,10 +229,37 @@ describe('RegistryClients', () => {
uri: mockRegistryClientEntity.uri,
fromTimestamp: '2023-10-08T12:00:00.000Z',
componentId: mockRegistryClientEntity.id,
- componentType: ComponentType.FlowRegistryClient
+ componentType: ComponentType.FlowRegistryClient
+ }
+ })
+ );
+ });
+
+ it('should dispatch navigateToComponentDocumentation action when viewRegistryClientDocumentation is called', async () => {
+ const { component, store } = await setup();
+ const mockRegistryClientEntity = createMockRegistryClientEntity();
+ jest.spyOn(store, 'dispatch');
+
+ component.viewRegistryClientDocumentation(mockRegistryClientEntity);
+
+ expect(store.dispatch).toHaveBeenCalledWith(
+ navigateToComponentDocumentation({
+ request: {
+ backNavigation: {
+ route: ['/settings', 'registry-clients', mockRegistryClientEntity.id],
+ routeBoundary: ['/documentation'],
+ context: 'Registry Client'
+ },
+ parameters: {
+ componentType: ComponentType.FlowRegistryClient,
+ type: mockRegistryClientEntity.component.type,
+ group: mockRegistryClientEntity.component.bundle.group,
+ artifact: mockRegistryClientEntity.component.bundle.artifact,
+ version: mockRegistryClientEntity.component.bundle.version
}
- })
- );
- });
+ }
+ })
+ );
});
});
+});
Review Comment:
I _think_ there is an extra `});` here. Can you please remove and it run prettier to format everything? Run the following from `/nifi/nifi-frontend/src/main/frontend`:
`npx nx prettier:format nifi`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-15253 - Add additionalDetails with Setup instructions for Azure Git DevOps Flow Registry Client [nifi]
Posted by "pvillard31 (via GitHub)" <gi...@apache.org>.
pvillard31 closed pull request #10562: NIFI-15253 - Add additionalDetails with Setup instructions for Azure Git DevOps Flow Registry Client
URL: https://github.com/apache/nifi/pull/10562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-15253 - Add additionalDetails with Setup instructions for Azure Git DevOps Flow Registry Client [nifi]
Posted by "mcgilman (via GitHub)" <gi...@apache.org>.
mcgilman commented on PR #10562:
URL: https://github.com/apache/nifi/pull/10562#issuecomment-3576004273
Reviewing...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-15253 - Add additionalDetails with Setup instructions for Azure Git DevOps Flow Registry Client [nifi]
Posted by "pvillard31 (via GitHub)" <gi...@apache.org>.
pvillard31 commented on code in PR #10562:
URL: https://github.com/apache/nifi/pull/10562#discussion_r2560508097
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/settings/ui/registry-clients/registry-clients.component.spec.ts:
##########
@@ -228,10 +229,37 @@ describe('RegistryClients', () => {
uri: mockRegistryClientEntity.uri,
fromTimestamp: '2023-10-08T12:00:00.000Z',
componentId: mockRegistryClientEntity.id,
- componentType: ComponentType.FlowRegistryClient
+ componentType: ComponentType.FlowRegistryClient
+ }
+ })
+ );
+ });
+
+ it('should dispatch navigateToComponentDocumentation action when viewRegistryClientDocumentation is called', async () => {
+ const { component, store } = await setup();
+ const mockRegistryClientEntity = createMockRegistryClientEntity();
+ jest.spyOn(store, 'dispatch');
+
+ component.viewRegistryClientDocumentation(mockRegistryClientEntity);
+
+ expect(store.dispatch).toHaveBeenCalledWith(
+ navigateToComponentDocumentation({
+ request: {
+ backNavigation: {
+ route: ['/settings', 'registry-clients', mockRegistryClientEntity.id],
+ routeBoundary: ['/documentation'],
+ context: 'Registry Client'
+ },
+ parameters: {
+ componentType: ComponentType.FlowRegistryClient,
+ type: mockRegistryClientEntity.component.type,
+ group: mockRegistryClientEntity.component.bundle.group,
+ artifact: mockRegistryClientEntity.component.bundle.artifact,
+ version: mockRegistryClientEntity.component.bundle.version
}
- })
- );
- });
+ }
+ })
+ );
});
});
+});
Review Comment:
It was just formatting, not looking the same as in my IDE, thanks for this command, should be much better now!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org