You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org> on 2009/09/10 14:52:57 UTC

[jira] Created: (QPID-2091) Only virtualhosts defined in the virtualhost.xml file are initialised

Only virtualhosts defined in the virtualhost.xml file are initialised
---------------------------------------------------------------------

                 Key: QPID-2091
                 URL: https://issues.apache.org/jira/browse/QPID-2091
             Project: Qpid
          Issue Type: Bug
          Components: Java Broker
    Affects Versions: 0.5
            Reporter: Martin Ritchie
            Assignee: Martin Ritchie
             Fix For: 0.6


The problem is that we use the virtualhosts defined in the virtualhost.xml file to control a loop for creating the virtualhosts.

If the virtualhost.xml file is not used in the configuration then no virtualhosts  are configured.

The problem in the ServerConfiguration class also means that any use of a CombinedConfiguration cannot override settings in the virtualhost.xml file.

The fix to address the lack of virtualhosts is to copy the values from the virtualhost.xml into the main config then use the main config as the source for the configured virtualhosts.

This however, will still leave us with the problem of virtualhost.xml still overriding any other configuration value. For now this is probably acceptable as the work around is not to reference the virtualhost.xml in the config.xml if you are using a Combined Configuration. If wish to have a virtualhost.xml file then that can easily be included in the combined file and will opporate as expected.



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Assigned: (QPID-2091) Only virtualhosts defined in the virtualhost.xml file are initialised

Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Ritchie reassigned QPID-2091:
------------------------------------

    Assignee:     (was: Martin Ritchie)

> Only virtualhosts defined in the virtualhost.xml file are initialised
> ---------------------------------------------------------------------
>
>                 Key: QPID-2091
>                 URL: https://issues.apache.org/jira/browse/QPID-2091
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: 0.5
>            Reporter: Martin Ritchie
>             Fix For: 0.7
>
>
> The problem is that we use the virtualhosts defined in the virtualhost.xml file to control a loop for creating the virtualhosts.
> If the virtualhost.xml file is not used in the configuration then no virtualhosts  are configured.
> The problem in the ServerConfiguration class also means that any use of a CombinedConfiguration cannot override settings in the virtualhost.xml file.
> The fix to address the lack of virtualhosts is to copy the values from the virtualhost.xml into the main config then use the main config as the source for the configured virtualhosts.
> This however, will still leave us with the problem of virtualhost.xml still overriding any other configuration value. For now this is probably acceptable as the work around is not to reference the virtualhost.xml in the config.xml if you are using a Combined Configuration. If wish to have a virtualhost.xml file then that can easily be included in the combined file and will opporate as expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2091) Only virtualhosts defined in the virtualhost.xml file are initialised

Posted by "Marnie McCormack (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marnie McCormack updated QPID-2091:
-----------------------------------

    Status: Open  (was: Ready To Review)

Really not keen on working around a config that all our users are making use of. Should address the underlying issue and then revert the removal of virtualhosts.xml imho.

> Only virtualhosts defined in the virtualhost.xml file are initialised
> ---------------------------------------------------------------------
>
>                 Key: QPID-2091
>                 URL: https://issues.apache.org/jira/browse/QPID-2091
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: 0.5
>            Reporter: Martin Ritchie
>            Assignee: Martin Ritchie
>             Fix For: 0.6
>
>
> The problem is that we use the virtualhosts defined in the virtualhost.xml file to control a loop for creating the virtualhosts.
> If the virtualhost.xml file is not used in the configuration then no virtualhosts  are configured.
> The problem in the ServerConfiguration class also means that any use of a CombinedConfiguration cannot override settings in the virtualhost.xml file.
> The fix to address the lack of virtualhosts is to copy the values from the virtualhost.xml into the main config then use the main config as the source for the configured virtualhosts.
> This however, will still leave us with the problem of virtualhost.xml still overriding any other configuration value. For now this is probably acceptable as the work around is not to reference the virtualhost.xml in the config.xml if you are using a Combined Configuration. If wish to have a virtualhost.xml file then that can easily be included in the combined file and will opporate as expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2091) Only virtualhosts defined in the virtualhost.xml file are initialised

Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Ritchie updated QPID-2091:
---------------------------------

    Status: Ready To Review  (was: In Progress)

> Only virtualhosts defined in the virtualhost.xml file are initialised
> ---------------------------------------------------------------------
>
>                 Key: QPID-2091
>                 URL: https://issues.apache.org/jira/browse/QPID-2091
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: 0.5
>            Reporter: Martin Ritchie
>            Assignee: Martin Ritchie
>             Fix For: 0.6
>
>
> The problem is that we use the virtualhosts defined in the virtualhost.xml file to control a loop for creating the virtualhosts.
> If the virtualhost.xml file is not used in the configuration then no virtualhosts  are configured.
> The problem in the ServerConfiguration class also means that any use of a CombinedConfiguration cannot override settings in the virtualhost.xml file.
> The fix to address the lack of virtualhosts is to copy the values from the virtualhost.xml into the main config then use the main config as the source for the configured virtualhosts.
> This however, will still leave us with the problem of virtualhost.xml still overriding any other configuration value. For now this is probably acceptable as the work around is not to reference the virtualhost.xml in the config.xml if you are using a Combined Configuration. If wish to have a virtualhost.xml file then that can easily be included in the combined file and will opporate as expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2091) Only virtualhosts defined in the virtualhost.xml file are initialised

Posted by "Marnie McCormack (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marnie McCormack updated QPID-2091:
-----------------------------------

    Fix Version/s:     (was: 0.6)
                   0.7

Moving out to 0.7, as per review comments needs some more work

> Only virtualhosts defined in the virtualhost.xml file are initialised
> ---------------------------------------------------------------------
>
>                 Key: QPID-2091
>                 URL: https://issues.apache.org/jira/browse/QPID-2091
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: 0.5
>            Reporter: Martin Ritchie
>            Assignee: Martin Ritchie
>             Fix For: 0.7
>
>
> The problem is that we use the virtualhosts defined in the virtualhost.xml file to control a loop for creating the virtualhosts.
> If the virtualhost.xml file is not used in the configuration then no virtualhosts  are configured.
> The problem in the ServerConfiguration class also means that any use of a CombinedConfiguration cannot override settings in the virtualhost.xml file.
> The fix to address the lack of virtualhosts is to copy the values from the virtualhost.xml into the main config then use the main config as the source for the configured virtualhosts.
> This however, will still leave us with the problem of virtualhost.xml still overriding any other configuration value. For now this is probably acceptable as the work around is not to reference the virtualhost.xml in the config.xml if you are using a Combined Configuration. If wish to have a virtualhost.xml file then that can easily be included in the combined file and will opporate as expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Commented: (QPID-2091) Only virtualhosts defined in the virtualhost.xml file are initialised

Posted by "Marnie McCormack (JIRA)" <qp...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790326#action_12790326 ] 

Marnie McCormack commented on QPID-2091:
----------------------------------------

Martin - QPID-2091 has a commit for a tactical? fix. Could you close this JIRA out if this is the case, and create a new for the strategic change in 0.7 (so 0.6 release notes can incude the work done). Or if I have the wrong end of the stick, move this item to 0.7 lock, stock and whatnot pls ? Thx.


> Only virtualhosts defined in the virtualhost.xml file are initialised
> ---------------------------------------------------------------------
>
>                 Key: QPID-2091
>                 URL: https://issues.apache.org/jira/browse/QPID-2091
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: 0.5
>            Reporter: Martin Ritchie
>            Assignee: Martin Ritchie
>             Fix For: 0.6
>
>
> The problem is that we use the virtualhosts defined in the virtualhost.xml file to control a loop for creating the virtualhosts.
> If the virtualhost.xml file is not used in the configuration then no virtualhosts  are configured.
> The problem in the ServerConfiguration class also means that any use of a CombinedConfiguration cannot override settings in the virtualhost.xml file.
> The fix to address the lack of virtualhosts is to copy the values from the virtualhost.xml into the main config then use the main config as the source for the configured virtualhosts.
> This however, will still leave us with the problem of virtualhost.xml still overriding any other configuration value. For now this is probably acceptable as the work around is not to reference the virtualhost.xml in the config.xml if you are using a Combined Configuration. If wish to have a virtualhost.xml file then that can easily be included in the combined file and will opporate as expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Commented: (QPID-2091) Only virtualhosts defined in the virtualhost.xml file are initialised

Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790704#action_12790704 ] 

Martin Ritchie commented on QPID-2091:
--------------------------------------

This issue has been addressed.  Virtualhosts defined in the virtualhosts.xml are not the only ones initalised any more.

I'll raise a JIRA for the fact that values configured in the virtualhost.xml will overwrite the main config.xml. Whilst sorting that out is a very small change we should be looking to migrate our config to a more manageable format.

> Only virtualhosts defined in the virtualhost.xml file are initialised
> ---------------------------------------------------------------------
>
>                 Key: QPID-2091
>                 URL: https://issues.apache.org/jira/browse/QPID-2091
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: 0.5
>            Reporter: Martin Ritchie
>            Assignee: Martin Ritchie
>             Fix For: 0.6
>
>
> The problem is that we use the virtualhosts defined in the virtualhost.xml file to control a loop for creating the virtualhosts.
> If the virtualhost.xml file is not used in the configuration then no virtualhosts  are configured.
> The problem in the ServerConfiguration class also means that any use of a CombinedConfiguration cannot override settings in the virtualhost.xml file.
> The fix to address the lack of virtualhosts is to copy the values from the virtualhost.xml into the main config then use the main config as the source for the configured virtualhosts.
> This however, will still leave us with the problem of virtualhost.xml still overriding any other configuration value. For now this is probably acceptable as the work around is not to reference the virtualhost.xml in the config.xml if you are using a Combined Configuration. If wish to have a virtualhost.xml file then that can easily be included in the combined file and will opporate as expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org