[GitHub] [lucene-solr] ErickErickson commented on pull request #2066: SOLR-14975: Optimize CoreContainer.getAllCoreNames and getLoadedCoreNames.

[GitBox <gi...@apache.org>]

ErickErickson commented on pull request #2066:
URL: https://github.com/apache/lucene-solr/pull/2066#issuecomment-723577563


   David:
   
   I’ve no objection to removing all the if (transientHandler==null) tests if we fail on initialization.
   
   Bruno:
   
   Yeah, I think 9.0 only is the way to go.
   
   > On Nov 8, 2020, at 1:35 AM, David Smiley <no...@github.com> wrote:
   > 
   > 
   > @dsmiley commented on this pull request.
   > 
   > In solr/core/src/java/org/apache/solr/core/SolrCores.java:
   > 
   > >      synchronized (modifyLock) {
   > -      set = new TreeSet<>(cores.keySet());
   > -      if (getTransientCacheHandler() != null) {
   > -        set.addAll(getTransientCacheHandler().getLoadedCoreNames());
   > -      }
   > +      TransientSolrCoreCache transientCoreCache = getTransientCacheHandler();
   > 
   > @ErickErickson IMO a bad config should stop Solr in its tracks. Why allow this? I'd rather disallow it and thus we'd always have either the default impl or some custom impl, but something.
   > 
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub, or unsubscribe.
   > 
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org