You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2015/06/01 07:04:43 UTC
Re: Review Request 34670: LENS-479 : Add server state persisting error
counter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34670/#review85930
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/LensServices.java
<https://reviews.apache.org/r/34670/#comment137752>
Defined in MetricService and also here?
- Amareshwari Sriramadasu
On May 29, 2015, 4:16 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34670/
> -----------------------------------------------------------
>
> (Updated May 29, 2015, 4:16 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/LENS-479
>
> Note - Did not use AtomicInterger since all the errors are in synchronized contexts.
>
> Build results-
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.912 s]
> [INFO] Lens ............................................... SUCCESS [ 4.246 s]
> [INFO] Lens API ........................................... SUCCESS [ 20.764 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 21.822 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:26 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 21.719 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 16.874 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:38 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.670 s]
> [INFO] Lens Server ........................................ SUCCESS [05:06 min]
> [INFO] Lens client ........................................ SUCCESS [ 37.343 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:02 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 10.199 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 7.692 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:18 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.651 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.191 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 17:42 min
> [INFO] Finished at: 2015-05-26T23:03:45+05:30
> [INFO] Final Memory: 120M/388M
> [INFO] ------------------------------------------------------------------------
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 9cfb65d
> lens-server/src/main/java/org/apache/lens/server/LensServices.java ab197ab
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 6e8b3a6
>
> Diff: https://reviews.apache.org/r/34670/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34670: LENS-479 : Add server state persisting error
counter
Posted by Yash Sharma <ya...@gmail.com>.
> On June 1, 2015, 5:04 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/LensServices.java, line 109
> > <https://reviews.apache.org/r/34670/diff/5/?file=974116#file974116line109>
> >
> > Defined in MetricService and also here?
Implemented. Reused from LensServices.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34670/#review85930
-----------------------------------------------------------
On June 1, 2015, 6:43 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34670/
> -----------------------------------------------------------
>
> (Updated June 1, 2015, 6:43 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/LENS-479
>
> Note - Did not use AtomicInterger since all the errors are in synchronized contexts.
>
> Build results-
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.912 s]
> [INFO] Lens ............................................... SUCCESS [ 4.246 s]
> [INFO] Lens API ........................................... SUCCESS [ 20.764 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 21.822 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:26 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 21.719 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 16.874 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:38 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.670 s]
> [INFO] Lens Server ........................................ SUCCESS [05:06 min]
> [INFO] Lens client ........................................ SUCCESS [ 37.343 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:02 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 10.199 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 7.692 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:18 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.651 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.191 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 17:42 min
> [INFO] Finished at: 2015-05-26T23:03:45+05:30
> [INFO] Final Memory: 120M/388M
> [INFO] ------------------------------------------------------------------------
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 9cfb65d
> lens-server/src/main/java/org/apache/lens/server/LensServices.java ab197ab
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 6e8b3a6
>
> Diff: https://reviews.apache.org/r/34670/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yash Sharma
>
>