You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jian Qiu <qi...@cn.ibm.com> on 2016/01/06 02:44:08 UTC
Re: Review Request 41787: Speed up Speed up SlaveRecoveryTest.*.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/
-----------------------------------------------------------
(Updated 一月 6, 2016, 1:44 a.m.)
Review request for mesos and Alexander Rukletsov.
Summary (updated)
-----------------
Speed up Speed up SlaveRecoveryTest.*.
Bugs: MESOS-4158
https://issues.apache.org/jira/browse/MESOS-4158
Repository: mesos
Description
-------
Some tests are sped up by using clock, while some relies on the fix of MESOS-4111 and a comment is put.
Diffs (updated)
-----
docs/configuration.md fb6f6784e5d11850ba0bafaeafa3213a1038e6b4
docs/executor-http-api.md fd80005002694bcc72abd04ceea35a2d00814401
docs/home.md bc22d3126f49e0213e6bb3a0e23e156cd2b247f1
docs/mesos-provisioner.md 06094f572a7917ddd1f7d73a6d855a9c9932cbab
include/mesos/docker/v1.hpp a155a8ec8e1895a793b98ac015b18ce6ac52956d
include/mesos/docker/v1.proto
include/mesos/docker/v2.hpp abab12b8f73564a6da1a0265a503d407a2849b3f
include/mesos/docker/v2.proto e2c0a131b8429ca086bc5cd09dccfe3e8d2e50ac
include/mesos/executor/executor.proto cc6b4f67da62dacf2fc649f00ba15a3fba98910b
include/mesos/v1/executor/executor.proto 4ecdaa0a468da1b271aa382a945d7e2a59c32449
include/mesos/v1/scheduler.hpp fc8ae50fa1a27ce1c52b2b51de54d2c54551f85e
src/Makefile.am 865926c5b46e42c5e29d3645a700c4ad20c1f11d
src/docker/spec.hpp 822b2383c6d6bd691cb1fdbfcd699ae3ae3585bd
src/docker/v1.hpp a155a8ec8e1895a793b98ac015b18ce6ac52956d
src/docker/v2.hpp abab12b8f73564a6da1a0265a503d407a2849b3f
src/examples/event_call_framework.cpp 8cfe1a0794b476bc099b067a9aeb79f099bbc18c
src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f
src/master/http.cpp d7afa2af989eebfc9039b3681f087ce570f601d5
src/scheduler/scheduler.cpp a17872b46ec600e0fae6c43247ccb63f5ee55ac0
src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp 7f441de097719114f81716caade44388720273f6
src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 6ae920a820a7604c97debf9fd21de24dda8e4d36
src/slave/containerizer/mesos/provisioner/docker/puller.cpp 5650f2f51c0ea31527c6c51eb498d87ddf2a4fec
src/slave/flags.hpp 6857fde027fd57b4934cb43ddf435d12900e0b87
src/slave/flags.cpp 19c2996c4572b992030f8824380f3979ced7e526
src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
src/tests/containerizer/provisioner_docker_tests.cpp 8d6a06057c7600aeb1aca76d4dfadc45b6eae99d
src/tests/health_check_tests.cpp 26d05e7f7db9306c8b9164e2e7f843793c909e67
src/tests/master_maintenance_tests.cpp 2da6a2d4b786d9c5f64be8b5ab95f70ef3d98f92
src/tests/mesos.hpp 49a4c48e6887e6f0921d96c359746e39be10e222
src/tests/mesos.cpp 082e57bc73fad02de77e16e4b34451e6c0903038
src/tests/persistent_volume_endpoints_tests.cpp f0cce190abc90f0fae84d6c3db20e8215c2d8132
src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8
src/webui/master/static/framework.html 9b28820dc93de1f66942b9b1f62a3288ee7609ac
src/webui/master/static/frameworks.html 15ff1e9cb6c70df8df47a1b939681abde591e010
src/webui/master/static/home.html f6d2f7d0923553ba0bb88e52f541c4e8c740c7c1
src/webui/master/static/js/controllers.js 36865f1cd6a4518ba30cd6e64d4d7347762066ec
src/webui/master/static/js/dashboard.js d6cbb3cc5aa92249c4b17c6d77260b215203d008
src/webui/master/static/js/services.js fa5cc35c1ef0e8ec149ed88852837058ec6ab13c
src/webui/master/static/offers.html 25e487193ae5244dde40d1de1d96ce892a7c67b9
src/webui/master/static/slave.html ad37ee2d1fab60e40762bf8c313754e1c59fe2a3
src/webui/master/static/slave_executor.html 9d582d54ce97f1b395f60acb28df95e4f9a48b3b
src/webui/master/static/slave_framework.html 96d788f04235b8e3881308818acba8f22d08e2ec
Diff: https://reviews.apache.org/r/41787/diff/
Testing
-------
SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms total)
SlaveRecoveryTest/0.ReconnectExecutor (333 ms total)
SlaveRecoveryTest/0.ReconcileKillTask (443 ms total)
SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total)
SlaveRecoveryTest/0.CleanupExecutor (474 ms total)
Thanks,
Jian Qiu
Re: Review Request 41787: Speed up Speed up SlaveRecoveryTest.*.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/#review113016
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41787]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 6, 2016, 1:48 a.m., Jian Qiu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41787/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2016, 1:48 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-4158
> https://issues.apache.org/jira/browse/MESOS-4158
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Some tests are sped up by using clock, while some relies on the fix of MESOS-4111 and a comment is put.
>
>
> Diffs
> -----
>
> src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8
>
> Diff: https://reviews.apache.org/r/41787/diff/
>
>
> Testing
> -------
>
> SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms total)
> SlaveRecoveryTest/0.ReconnectExecutor (333 ms total)
> SlaveRecoveryTest/0.ReconcileKillTask (443 ms total)
> SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total)
> SlaveRecoveryTest/0.CleanupExecutor (474 ms total)
>
>
> Thanks,
>
> Jian Qiu
>
>
Re: Review Request 41787: Speed up SlaveRecoveryTest.*.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/#review113260
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41787]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 7, 2016, 1:48 p.m., Jian Qiu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41787/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2016, 1:48 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-4158
> https://issues.apache.org/jira/browse/MESOS-4158
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Some tests are sped up by using clock, while some relies on the fix of MESOS-4111 and a comment is put.
>
>
> Diffs
> -----
>
> src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8
>
> Diff: https://reviews.apache.org/r/41787/diff/
>
>
> Testing
> -------
>
> SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms total)
> SlaveRecoveryTest/0.ReconnectExecutor (333 ms total)
> SlaveRecoveryTest/0.ReconcileKillTask (443 ms total)
> SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total)
> SlaveRecoveryTest/0.CleanupExecutor (474 ms total)
>
>
> Thanks,
>
> Jian Qiu
>
>
Re: Review Request 41787: Speed up SlaveRecoveryTest.*.
Posted by Jian Qiu <qi...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/
-----------------------------------------------------------
(Updated 一月 7, 2016, 1:48 p.m.)
Review request for mesos and Alexander Rukletsov.
Bugs: MESOS-4158
https://issues.apache.org/jira/browse/MESOS-4158
Repository: mesos
Description
-------
Some tests are sped up by using clock, while some relies on the fix of MESOS-4111 and a comment is put.
Diffs (updated)
-----
src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8
Diff: https://reviews.apache.org/r/41787/diff/
Testing
-------
SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms total)
SlaveRecoveryTest/0.ReconnectExecutor (333 ms total)
SlaveRecoveryTest/0.ReconcileKillTask (443 ms total)
SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total)
SlaveRecoveryTest/0.CleanupExecutor (474 ms total)
Thanks,
Jian Qiu
Re: Review Request 41787: Speed up SlaveRecoveryTest.*.
Posted by Jian Qiu <qi...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/
-----------------------------------------------------------
(Updated 一月 6, 2016, 7:43 a.m.)
Review request for mesos and Alexander Rukletsov.
Summary (updated)
-----------------
Speed up SlaveRecoveryTest.*.
Bugs: MESOS-4158
https://issues.apache.org/jira/browse/MESOS-4158
Repository: mesos
Description
-------
Some tests are sped up by using clock, while some relies on the fix of MESOS-4111 and a comment is put.
Diffs
-----
src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8
Diff: https://reviews.apache.org/r/41787/diff/
Testing
-------
SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms total)
SlaveRecoveryTest/0.ReconnectExecutor (333 ms total)
SlaveRecoveryTest/0.ReconcileKillTask (443 ms total)
SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total)
SlaveRecoveryTest/0.CleanupExecutor (474 ms total)
Thanks,
Jian Qiu
Re: Review Request 41787: Speed up Speed up SlaveRecoveryTest.*.
Posted by Jian Qiu <qi...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/
-----------------------------------------------------------
(Updated 一月 6, 2016, 1:48 a.m.)
Review request for mesos and Alexander Rukletsov.
Bugs: MESOS-4158
https://issues.apache.org/jira/browse/MESOS-4158
Repository: mesos
Description
-------
Some tests are sped up by using clock, while some relies on the fix of MESOS-4111 and a comment is put.
Diffs (updated)
-----
src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8
Diff: https://reviews.apache.org/r/41787/diff/
Testing
-------
SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms total)
SlaveRecoveryTest/0.ReconnectExecutor (333 ms total)
SlaveRecoveryTest/0.ReconcileKillTask (443 ms total)
SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total)
SlaveRecoveryTest/0.CleanupExecutor (474 ms total)
Thanks,
Jian Qiu