You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Stefan <lu...@gmx.de> on 2016/11/29 23:27:13 UTC
Re: [jira] [Resolved] (SVN-4660) svn info --show-item=revision
produces trailing whitespace
Would it be better to only list 1.9.5 as fix version in such cases?
I mean: It's practical implicit that any fix present in a released
version is also present on trunk, no?
On 11/29/2016 17:42, Evgeny Kotkov (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/SVN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Evgeny Kotkov resolved SVN-4660.
> --------------------------------
> Resolution: Fixed
> Fix Version/s: (was: 1.10.0)
> 1.9.5
> trunk
>
> Fix for this issue was included in Subversion 1.9.5.
>
>> svn info --show-item=revision produces trailing whitespace
>> ----------------------------------------------------------
>>
>> Key: SVN-4660
>> URL: https://issues.apache.org/jira/browse/SVN-4660
>> Project: Subversion
>> Issue Type: Bug
>> Components: cmdline client
>> Affects Versions: 1.9.4
>> Reporter: Stefan Hett
>> Fix For: trunk, 1.9.5
>>
>>
>> Steps to reproduce:
>> 1. Run svn info --show-item=revision >out.txt
>> Expected result:
>> The file out.txt contains just the revision number and a newline.
>> Actual result:
>> The file out.txt contains the revision number, followed by some whitespaces and a newline.
>> The issue was passed on to the dev list here: http://mail-archives.apache.org/mod_mbox/subversion-dev/201610.mbox/%3C20161028184002.GA25363%40fujitsu.shahaf.local2%3E
>> Rational for this being a bug/unintended behavior:
>> 1. One (if not the) main use-case for the newly introduced --show-item option is to make it easier to be used in scripts. For revisions, I used that to generate a revision range as in: -rXXX:YYY. XXX was retrieved using --show-item=revision. Since that produced unexpected trailing whitespaces the script command resulted in [...] -rXXX :YYY [...] which obviously caused an error message which was hard to debug since I didn't immediately get the idea that the trailing whitespaces might cause the script error I saw.
>> 2. It's not what the documentation in the release notes state:
>> https://subversion.apache.org/docs/release-notes/1.9.html#svn-info-item
>> where it's explicitly shown that the reported revision number does not have any trailing whitespace:
>> {noformat}
>> ## Display the youngest revision of a repository:
>> % svn info --show-item=revision https://svn.apache.org/repos/asf/subversion/trunk
>> 1693514
>> ## Find the root directory of a working copy:
>> % svn info --show-item=wc-root
>> /home/jrandom/src/svn/trunk
>> {noformat}
>> Note: The issue was not present in SVN < 1.9, since the --show-item-option was added in SVN 1.9.0. Also I only tested it explicitly with SVN 1.9.4 but since the code change was introduced in 1.9.0 I'm quite certain the behavior exists in SVN 1.9.0-1.9.3 as well.
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
>
Re: [jira] [Resolved] (SVN-4660) svn info --show-item=revision
produces trailing whitespace
Posted by Stefan Hett <st...@egosoft.com>.
On 11/30/2016 11:32 AM, Evgeny Kotkov wrote:
> Stefan Hett <lu...@gmx.de> writes:
>
>> Would it be better to only list 1.9.5 as fix version in such cases?
>> I mean: It's practical implicit that any fix present in a released
>> version is also present on trunk, no?
>>
>>> Evgeny Kotkov resolved SVN-4660.
>>> --------------------------------
>>> Resolution: Fixed
>>> Fix Version/s: (was: 1.10.0)
>>> 1.9.5
>>> trunk
>>>
>>> Fix for this issue was included in Subversion 1.9.5.
> I changed this, because "Fix Version(s): 1.10.0" is misleading for the
> users, as it refers to an unreleased version.
>
> No opinion on whether we should remove "trunk" from here. I am fine
> with either approach, but what we have right now is consistent between
> different JIRA tickets.
>
>
> Regards,
> Evgeny Kotkov
>
Sounds reasonable to leave it then.
Just bare in mind that IMO it would be good to change the name of the
version (trunk) to 1.10(.0) upon release of the new version and create a
new version (named "trunk") then.
--
Regards,
Stefan Hett
Re: [jira] [Resolved] (SVN-4660) svn info --show-item=revision
produces trailing whitespace
Posted by Evgeny Kotkov <ev...@visualsvn.com>.
Stefan Hett <lu...@gmx.de> writes:
> Would it be better to only list 1.9.5 as fix version in such cases?
> I mean: It's practical implicit that any fix present in a released
> version is also present on trunk, no?
>
>> Evgeny Kotkov resolved SVN-4660.
>> --------------------------------
>> Resolution: Fixed
>> Fix Version/s: (was: 1.10.0)
>> 1.9.5
>> trunk
>>
>> Fix for this issue was included in Subversion 1.9.5.
I changed this, because "Fix Version(s): 1.10.0" is misleading for the
users, as it refers to an unreleased version.
No opinion on whether we should remove "trunk" from here. I am fine
with either approach, but what we have right now is consistent between
different JIRA tickets.
Regards,
Evgeny Kotkov
Re: [jira] [Resolved] (SVN-4660) svn info --show-item=revision
produces trailing whitespace
Posted by Stefan <lu...@posteo.de>.
On 11/30/2016 00:27, Stefan wrote:
> Would it be better to only list 1.9.5 as fix version in such cases?
> I mean: It's practical implicit that any fix present in a released
> version is also present on trunk, no?
Answering my own question: I understand it would make sense, if the
current version named "trunk" will be renamed to 1.10.0 (or whatever
version number the next release will get). In that case the issue will
be listed as fixed for the 1.9 branch on 1.9.5 and for the 1.10 branch
since 1.10.0.
>
> On 11/29/2016 17:42, Evgeny Kotkov (JIRA) wrote:
>> [ https://issues.apache.org/jira/browse/SVN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>>
>> Evgeny Kotkov resolved SVN-4660.
>> --------------------------------
>> Resolution: Fixed
>> Fix Version/s: (was: 1.10.0)
>> 1.9.5
>> trunk
>>
>> Fix for this issue was included in Subversion 1.9.5.
>>
>>> svn info --show-item=revision produces trailing whitespace
>>> ----------------------------------------------------------
>>>
>>> Key: SVN-4660
>>> URL: https://issues.apache.org/jira/browse/SVN-4660
>>> Project: Subversion
>>> Issue Type: Bug
>>> Components: cmdline client
>>> Affects Versions: 1.9.4
>>> Reporter: Stefan Hett
>>> Fix For: trunk, 1.9.5
>>>
>>>
>>> Steps to reproduce:
>>> 1. Run svn info --show-item=revision >out.txt
>>> Expected result:
>>> The file out.txt contains just the revision number and a newline.
>>> Actual result:
>>> The file out.txt contains the revision number, followed by some whitespaces and a newline.
>>> The issue was passed on to the dev list here: http://mail-archives.apache.org/mod_mbox/subversion-dev/201610.mbox/%3C20161028184002.GA25363%40fujitsu.shahaf.local2%3E
>>> Rational for this being a bug/unintended behavior:
>>> 1. One (if not the) main use-case for the newly introduced --show-item option is to make it easier to be used in scripts. For revisions, I used that to generate a revision range as in: -rXXX:YYY. XXX was retrieved using --show-item=revision. Since that produced unexpected trailing whitespaces the script command resulted in [...] -rXXX :YYY [...] which obviously caused an error message which was hard to debug since I didn't immediately get the idea that the trailing whitespaces might cause the script error I saw.
>>> 2. It's not what the documentation in the release notes state:
>>> https://subversion.apache.org/docs/release-notes/1.9.html#svn-info-item
>>> where it's explicitly shown that the reported revision number does not have any trailing whitespace:
>>> {noformat}
>>> ## Display the youngest revision of a repository:
>>> % svn info --show-item=revision https://svn.apache.org/repos/asf/subversion/trunk
>>> 1693514
>>> ## Find the root directory of a working copy:
>>> % svn info --show-item=wc-root
>>> /home/jrandom/src/svn/trunk
>>> {noformat}
>>> Note: The issue was not present in SVN < 1.9, since the --show-item-option was added in SVN 1.9.0. Also I only tested it explicitly with SVN 1.9.4 but since the code change was introduced in 1.9.0 I'm quite certain the behavior exists in SVN 1.9.0-1.9.3 as well.
>>
>> --
>> This message was sent by Atlassian JIRA
>> (v6.3.4#6332)
>>
>
Regards,
Stefan