You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/02/16 08:15:37 UTC
[GitHub] [rocketmq-client-go] xujianhai666 opened a new pull request #414:
fix(consumer): use sync offset fix instead if async
xujianhai666 opened a new pull request #414: fix(consumer): use sync offset fix instead if async
URL: https://github.com/apache/rocketmq-client-go/pull/414
Closes #413
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] codecov-io commented on issue #414:
fix(consumer): use sync offset fix instead if async
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #414: fix(consumer): use sync offset fix instead if async
URL: https://github.com/apache/rocketmq-client-go/pull/414#issuecomment-586680481
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/414?src=pr&el=h1) Report
> Merging [#414](https://codecov.io/gh/apache/rocketmq-client-go/pull/414?src=pr&el=desc) into [native](https://codecov.io/gh/apache/rocketmq-client-go/commit/adc707f730e136a1969d4f0ab7adffcb173ebd9f?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/rocketmq-client-go/pull/414?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## native #414 +/- ##
==========================================
+ Coverage 24.9% 24.91% +<.01%
==========================================
Files 48 48
Lines 5480 5478 -2
==========================================
Hits 1365 1365
+ Misses 3928 3926 -2
Partials 187 187
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/414?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [consumer/push\_consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/414/diff?src=pr&el=tree#diff-Y29uc3VtZXIvcHVzaF9jb25zdW1lci5nbw==) | `12.41% <0%> (+0.03%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/414?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/414?src=pr&el=footer). Last update [adc707f...46ede68](https://codecov.io/gh/apache/rocketmq-client-go/pull/414?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] ShannonDing merged pull request #414:
fix(consumer): use sync offset fix instead if async
Posted by GitBox <gi...@apache.org>.
ShannonDing merged pull request #414: fix(consumer): use sync offset fix instead if async
URL: https://github.com/apache/rocketmq-client-go/pull/414
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services