You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/08/29 23:12:54 UTC
[GitHub] codecov-io commented on issue #5774: [sqllab] Include visual
feedback that SQL Lab query is limited
codecov-io commented on issue #5774: [sqllab] Include visual feedback that SQL Lab query is limited
URL: https://github.com/apache/incubator-superset/pull/5774#issuecomment-417137101
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5774?src=pr&el=h1) Report
> Merging [#5774](https://codecov.io/gh/apache/incubator-superset/pull/5774?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/00cc6e981e946b29d582ab78e74967a2e009deec?src=pr&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/5774?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5774 +/- ##
==========================================
- Coverage 63.8% 63.77% -0.04%
==========================================
Files 364 364
Lines 23066 23098 +32
Branches 2568 2572 +4
==========================================
+ Hits 14717 14730 +13
- Misses 8334 8353 +19
Partials 15 15
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5774?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/5774/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `71.95% <100%> (+0.17%)` | :arrow_up: |
| [superset/assets/src/visualizations/partition.js](https://codecov.io/gh/apache/incubator-superset/pull/5774/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9wYXJ0aXRpb24uanM=) | `0% <0%> (ø)` | :arrow_up: |
| [...uperset/assets/src/visualizations/deckgl/multi.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5774/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbXVsdGkuanN4) | `0% <0%> (ø)` | :arrow_up: |
| [...ssets/src/visualizations/deckgl/layers/scatter.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5774/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL3NjYXR0ZXIuanN4) | `0% <0%> (ø)` | :arrow_up: |
| [...sualizations/deckgl/CategoricalDeckGLContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5774/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvQ2F0ZWdvcmljYWxEZWNrR0xDb250YWluZXIuanN4) | `0% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/visualizations/rose.js](https://codecov.io/gh/apache/incubator-superset/pull/5774/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9yb3NlLmpz) | `0% <0%> (ø)` | :arrow_up: |
| [...et/assets/src/visualizations/deckgl/layers/arc.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5774/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL2FyYy5qc3g=) | `0% <0%> (ø)` | :arrow_up: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/5774/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `81.38% <0%> (+0.05%)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/5774/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `80.91% <0%> (+2.29%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5774?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5774?src=pr&el=footer). Last update [00cc6e9...d2bb9cf](https://codecov.io/gh/apache/incubator-superset/pull/5774?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org