You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "ikfid (via GitHub)" <gi...@apache.org> on 2024/04/05 17:05:12 UTC

[PR] MongoDBCsv empty first column parsing fix [commons-csv]

ikfid opened a new pull request, #412:
URL: https://github.com/apache/commons-csv/pull/412

   when printed a record with an empty first column is printed with MongoDBCsv predefined format, the csv file cannot be then parsed with the same MongoDBCsv predefined format.
   
   this is due to the conflict between 'escape' and 'quote' character branches in Lexer. They are both set to ' " ' for MongoDBCsv.
   
   fix: in Lexer reordered 'escape' and 'quote' branches.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MongoDBCsv empty first column parsing fix [commons-csv]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #412:
URL: https://github.com/apache/commons-csv/pull/412#issuecomment-2040890330

   ## [Codecov](https://app.codecov.io/gh/apache/commons-csv/pull/412?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 97.89%. Comparing base [(`08b09ed`)](https://app.codecov.io/gh/apache/commons-csv/commit/08b09ed8927a5d9b19c1d4215c238cf6f07c4588?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`df7c340`)](https://app.codecov.io/gh/apache/commons-csv/pull/412?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 79 commits behind head on master.
   
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #412      +/-   ##
   ============================================
   - Coverage     98.35%   97.89%   -0.46%     
   - Complexity      541      550       +9     
   ============================================
     Files            10       10              
     Lines          1152     1189      +37     
     Branches        202      212      +10     
   ============================================
   + Hits           1133     1164      +31     
   + Misses            7        6       -1     
   - Partials         12       19       +7     
   ```
   
   
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/commons-csv/pull/412?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MongoDB CSV empty first column parsing fix [commons-csv]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #412:
URL: https://github.com/apache/commons-csv/pull/412#issuecomment-2041069796

   TY @ikfid for your PR. Merged. Please note the changes I made to the test to convert it into a proper JUnit test; there is no need to handle exceptions "manually": https://github.com/apache/commons-csv/commit/70c9418e71c32a6a8248f9b2e62aad6b3892a485
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MongoDB CSV empty first column parsing fix [commons-csv]

Posted by "ikfid (via GitHub)" <gi...@apache.org>.
ikfid commented on PR #412:
URL: https://github.com/apache/commons-csv/pull/412#issuecomment-2041072248

   @garydgregory , thanks !) the proper test is way better :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MongoDB CSV empty first column parsing fix [commons-csv]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #412:
URL: https://github.com/apache/commons-csv/pull/412


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org