[GitHub] [incubator-superset] cgivre commented on a change in pull request #6610: [WIP] Add support for Apache Drill

[GitBox <gi...@apache.org>]

cgivre commented on a change in pull request #6610: [WIP] Add support for Apache Drill
URL: https://github.com/apache/incubator-superset/pull/6610#discussion_r287611775
 
 

 ##########
 File path: superset/db_engine_specs.py
 ##########
 @@ -721,6 +721,70 @@ def get_table_names(cls, inspector, schema):
         return sorted(inspector.get_table_names())
 
 
+class DrillEngineSpec(BaseEngineSpec):
+    """Engine spec for Apache Drill"""
+    engine = 'drill'
 
 Review comment:
   I think I'm going to leave this out for the moment as Drill allows some schema variants that it might break.   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org