You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/08/29 07:58:47 UTC

[GitHub] [airflow] ashb commented on a change in pull request #5915: [AIRFLOW-5312] Fix timeout issue in pod launcher / KubernetesPodOperator

ashb commented on a change in pull request #5915: [AIRFLOW-5312] Fix timeout issue in pod launcher / KubernetesPodOperator
URL: https://github.com/apache/airflow/pull/5915#discussion_r318931857
 
 

 ##########
 File path: airflow/contrib/kubernetes/pod_launcher.py
 ##########
 @@ -96,9 +98,14 @@ def run_pod(self, pod, startup_timeout=120, get_logs=True):
 
         return self._monitor_pod(pod, get_logs)
 
+    @tenacity.retry(
 
 Review comment:
   I'm not sure we want to retry here -- most of the individual components have retries on, and if it fails after we've called read_pod_logs then all the container logs would be duplicated.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services