You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Henrique Mendonça (JIRA)" <ji...@apache.org> on 2013/09/19 12:37:53 UTC

[jira] [Updated] (THRIFT-1772) Serialization does not check types of embedded structures.

     [ https://issues.apache.org/jira/browse/THRIFT-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henrique Mendonça updated THRIFT-1772:
--------------------------------------

    Issue Type: Improvement  (was: Bug)
    
> Serialization does not check types of embedded structures.
> ----------------------------------------------------------
>
>                 Key: THRIFT-1772
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1772
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Python - Library
>    Affects Versions: 0.8, 0.9
>            Reporter: Avi Flamholz
>         Attachments: thrift-py-serialize-check-struct-type.patch
>
>
> Consider the following struct definitions:
> struct Point {
> 	1: required double x;
> 	2: required double y;
> }
> struct Review {
> 	1: required i32 rating;
> 	2: optional string text;
> }
> struct Place {
> 	1: required string name;
> 	2: required Point location;
> 	3: optional Review review;
> }
> If I create a Place object and set the location field to a Review, it will serialize no problem.
> place = Place(name="avi's place", location=Review(rating=1.0))
> transportOut = TTransport.TMemoryBuffer()
> protocolOut = TBinaryProtocol.TBinaryProtocol(transportOut)
> place.write(protocolOut)
> serialized = transportOut.getvalue()
> This is confusing because if I set an i32 field to a string serialization does raise an error.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira