You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Nixon Rodrigues <ni...@freestoneinfotech.com> on 2020/09/17 09:26:17 UTC
Review Request 72879: ATLAS-3946 : Filter TypeDefs in Metrics API and
show data accordingly
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72879/
-----------------------------------------------------------
Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, and Sarath Subramanian.
Bugs: ATLAS-3946
https://issues.apache.org/jira/browse/ATLAS-3946
Repository: atlas
Description
-------
Filter TypeDefs in Metrics API and show data accordingly, currently data is shown for all types even if user do not have access to those types.
This patch filterTypeDefs after authorization and updates the data for required types.
Diffs
-----
repository/src/main/java/org/apache/atlas/services/MetricsService.java 7917f32e5
webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java e74a9e93a
Diff: https://reviews.apache.org/r/72879/diff/1/
Testing
-------
Tested Statistics UI from different users with different policies for entityType and classfication.
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/25/console
Thanks,
Nixon Rodrigues
Re: Review Request 72879: ATLAS-3946 : Filter TypeDefs in Metrics API
and show data accordingly
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72879/#review221885
-----------------------------------------------------------
Fix it, then Ship it!
repository/src/main/java/org/apache/atlas/services/MetricsService.java
Lines 241 (patched)
<https://reviews.apache.org/r/72879/#comment310949>
Instead of parameter 'typesDef', consider returning from this method:
AtlasTypesDef getTypesDef() {
AtlasTypesDef ret = new AtlasTypesDef();
...
return ret;
}
- Madhan Neethiraj
On Sept. 17, 2020, 9:26 a.m., Nixon Rodrigues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72879/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2020, 9:26 a.m.)
>
>
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3946
> https://issues.apache.org/jira/browse/ATLAS-3946
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Filter TypeDefs in Metrics API and show data accordingly, currently data is shown for all types even if user do not have access to those types.
>
> This patch filterTypeDefs after authorization and updates the data for required types.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/services/MetricsService.java 7917f32e5
> webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java e74a9e93a
>
>
> Diff: https://reviews.apache.org/r/72879/diff/1/
>
>
> Testing
> -------
>
> Tested Statistics UI from different users with different policies for entityType and classfication.
>
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/25/console
>
>
> Thanks,
>
> Nixon Rodrigues
>
>
Re: Review Request 72879: ATLAS-3946 : Filter TypeDefs in Metrics API
and show data accordingly
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72879/#review221888
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/services/MetricsService.java
Line 129 (original), 139 (patched)
<https://reviews.apache.org/r/72879/#comment310950>
Shouldn't entityDefs be used here, instead of typeRegistry.getAllEntityTypes()? Please review.
- Madhan Neethiraj
On Sept. 17, 2020, 5:24 p.m., Nixon Rodrigues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72879/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2020, 5:24 p.m.)
>
>
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3946
> https://issues.apache.org/jira/browse/ATLAS-3946
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Filter TypeDefs in Metrics API and show data accordingly, currently data is shown for all types even if user do not have access to those types.
>
> This patch filterTypeDefs after authorization and updates the data for required types.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/services/MetricsService.java 7917f32e5
> webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java e74a9e93a
>
>
> Diff: https://reviews.apache.org/r/72879/diff/2/
>
>
> Testing
> -------
>
> Tested Statistics UI from different users with different policies for entityType and classfication.
>
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/25/console
>
>
> Thanks,
>
> Nixon Rodrigues
>
>
Re: Review Request 72879: ATLAS-3946 : Filter TypeDefs in Metrics API
and show data accordingly
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72879/#review221892
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/services/MetricsService.java
Lines 147 (patched)
<https://reviews.apache.org/r/72879/#comment310951>
entityDef.subTypes includes only direct sub-types. To get sub-types in all levels, consider the following:
AtlasEntityType entityType = typeRegistry.getEntityType(entityDef.getName();
for (String type : entityType.getTypeAndAllSubTypes()) {
... earlier implementation
}
- Madhan Neethiraj
On Sept. 18, 2020, 8:59 a.m., Nixon Rodrigues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72879/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2020, 8:59 a.m.)
>
>
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3946
> https://issues.apache.org/jira/browse/ATLAS-3946
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Filter TypeDefs in Metrics API and show data accordingly, currently data is shown for all types even if user do not have access to those types.
>
> This patch filterTypeDefs after authorization and updates the data for required types.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/services/MetricsService.java 7917f32e5
> webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java e74a9e93a
>
>
> Diff: https://reviews.apache.org/r/72879/diff/3/
>
>
> Testing
> -------
>
> Tested Statistics UI from different users with different policies for entityType and classfication.
>
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/25/console
>
>
> Thanks,
>
> Nixon Rodrigues
>
>
Re: Review Request 72879: ATLAS-3946 : Filter TypeDefs in Metrics API
and show data accordingly
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72879/#review221903
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Sept. 19, 2020, 5:21 p.m., Nixon Rodrigues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72879/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2020, 5:21 p.m.)
>
>
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3946
> https://issues.apache.org/jira/browse/ATLAS-3946
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Filter TypeDefs in Metrics API and show data accordingly, currently data is shown for all types even if user do not have access to those types.
>
> This patch filterTypeDefs after authorization and updates the data for required types.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/services/MetricsService.java 7917f32e5
> webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java e74a9e93a
>
>
> Diff: https://reviews.apache.org/r/72879/diff/4/
>
>
> Testing
> -------
>
> Tested Statistics UI from different users with different policies for entityType and classfication.
>
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/25/console
>
>
> Thanks,
>
> Nixon Rodrigues
>
>
Re: Review Request 72879: ATLAS-3946 : Filter TypeDefs in Metrics API
and show data accordingly
Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72879/
-----------------------------------------------------------
(Updated Sept. 19, 2020, 5:21 p.m.)
Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, and Sarath Subramanian.
Changes
-------
Handled review comment from Madhan for refactoring the code.
Bugs: ATLAS-3946
https://issues.apache.org/jira/browse/ATLAS-3946
Repository: atlas
Description
-------
Filter TypeDefs in Metrics API and show data accordingly, currently data is shown for all types even if user do not have access to those types.
This patch filterTypeDefs after authorization and updates the data for required types.
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/services/MetricsService.java 7917f32e5
webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java e74a9e93a
Diff: https://reviews.apache.org/r/72879/diff/4/
Changes: https://reviews.apache.org/r/72879/diff/3-4/
Testing
-------
Tested Statistics UI from different users with different policies for entityType and classfication.
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/25/console
Thanks,
Nixon Rodrigues
Re: Review Request 72879: ATLAS-3946 : Filter TypeDefs in Metrics API
and show data accordingly
Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72879/
-----------------------------------------------------------
(Updated Sept. 18, 2020, 8:59 a.m.)
Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, and Sarath Subramanian.
Changes
-------
Handled review comment from Madhan for
>> Shouldn't entityDefs be used here, instead of typeRegistry.getAllEntityTypes()? Please review.
Used filtered entityDefs instead typeRegistry.getAllEntityTypes()
Bugs: ATLAS-3946
https://issues.apache.org/jira/browse/ATLAS-3946
Repository: atlas
Description
-------
Filter TypeDefs in Metrics API and show data accordingly, currently data is shown for all types even if user do not have access to those types.
This patch filterTypeDefs after authorization and updates the data for required types.
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/services/MetricsService.java 7917f32e5
webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java e74a9e93a
Diff: https://reviews.apache.org/r/72879/diff/3/
Changes: https://reviews.apache.org/r/72879/diff/2-3/
Testing
-------
Tested Statistics UI from different users with different policies for entityType and classfication.
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/25/console
Thanks,
Nixon Rodrigues
Re: Review Request 72879: ATLAS-3946 : Filter TypeDefs in Metrics API
and show data accordingly
Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72879/
-----------------------------------------------------------
(Updated Sept. 17, 2020, 5:24 p.m.)
Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, and Sarath Subramanian.
Changes
-------
Updated patch with review comment from Madhan.
Bugs: ATLAS-3946
https://issues.apache.org/jira/browse/ATLAS-3946
Repository: atlas
Description
-------
Filter TypeDefs in Metrics API and show data accordingly, currently data is shown for all types even if user do not have access to those types.
This patch filterTypeDefs after authorization and updates the data for required types.
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/services/MetricsService.java 7917f32e5
webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java e74a9e93a
Diff: https://reviews.apache.org/r/72879/diff/2/
Changes: https://reviews.apache.org/r/72879/diff/1-2/
Testing
-------
Tested Statistics UI from different users with different policies for entityType and classfication.
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/25/console
Thanks,
Nixon Rodrigues
Re: Review Request 72879: ATLAS-3946 : Filter TypeDefs in Metrics API
and show data accordingly
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72879/#review221886
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On Sept. 17, 2020, 2:26 a.m., Nixon Rodrigues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72879/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2020, 2:26 a.m.)
>
>
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3946
> https://issues.apache.org/jira/browse/ATLAS-3946
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Filter TypeDefs in Metrics API and show data accordingly, currently data is shown for all types even if user do not have access to those types.
>
> This patch filterTypeDefs after authorization and updates the data for required types.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/services/MetricsService.java 7917f32e5
> webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java e74a9e93a
>
>
> Diff: https://reviews.apache.org/r/72879/diff/1/
>
>
> Testing
> -------
>
> Tested Statistics UI from different users with different policies for entityType and classfication.
>
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/25/console
>
>
> Thanks,
>
> Nixon Rodrigues
>
>