You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/01/16 01:05:43 UTC

[GitHub] [incubator-tvm] hcho3 commented on issue #4707: [Relay][Frontend][TF] Fix handling of 0D scalar Constant

hcho3 commented on issue #4707: [Relay][Frontend][TF] Fix handling of 0D scalar Constant
URL: https://github.com/apache/incubator-tvm/pull/4707#issuecomment-574931580
 
 
   Looks like this change breaks the following snippet:
   https://github.com/apache/incubator-tvm/blob/49d31443c4b65c814a3da6decc363a881c05b372/tests/python/frontend/tensorflow/test_forward.py#L2352-L2354
   
   The `size_value` variable is set to `2` (0D tensor) so `size_tensor` should have been `(2,)` (1D tensor). But currently, the TF frontend seems to silently ignore `tf.expand_dims`; `size_tensor` is simply set to `2`. 
   
   Ideal fix would be to make strict distinction between 1D `(1,)` tensors and 0D tensors. Unfortunately, I do not currently have bandwidth to perform the necessary audit of the TF frontend.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services