You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by sl...@apache.org on 2021/10/10 20:12:46 UTC
[maven] branch master updated: [MNG-7291] Avoid String
concatenation in loops (#572)
This is an automated email from the ASF dual-hosted git repository.
slachiewicz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven.git
The following commit(s) were added to refs/heads/master by this push:
new b31f3ae [MNG-7291] Avoid String concatenation in loops (#572)
b31f3ae is described below
commit b31f3aeef3a7b9e6ef341af954b1cfafc1a629c6
Author: Arturo Bernal <ar...@gmail.com>
AuthorDate: Sun Oct 10 22:12:41 2021 +0200
[MNG-7291] Avoid String concatenation in loops (#572)
---
.../maven/lifecycle/internal/MojoDescriptorCreator.java | 2 +-
.../maven/plugin/prefix/NoPluginFoundForPrefixException.java | 12 ++++++------
.../org/apache/maven/model/building/DefaultModelBuilder.java | 10 ++++++----
3 files changed, 13 insertions(+), 11 deletions(-)
diff --git a/maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoDescriptorCreator.java b/maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoDescriptorCreator.java
index e0647af..053d851 100644
--- a/maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoDescriptorCreator.java
+++ b/maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoDescriptorCreator.java
@@ -229,7 +229,7 @@ public class MojoDescriptorCreator
resolvePluginVersion( plugin, session, project );
}
- return pluginManager.getMojoDescriptor( plugin, goal, project.getRemotePluginRepositories(),
+ return pluginManager.getMojoDescriptor( plugin, goal.toString(), project.getRemotePluginRepositories(),
session.getRepositorySession() );
}
diff --git a/maven-core/src/main/java/org/apache/maven/plugin/prefix/NoPluginFoundForPrefixException.java b/maven-core/src/main/java/org/apache/maven/plugin/prefix/NoPluginFoundForPrefixException.java
index 6612913..de53d51 100644
--- a/maven-core/src/main/java/org/apache/maven/plugin/prefix/NoPluginFoundForPrefixException.java
+++ b/maven-core/src/main/java/org/apache/maven/plugin/prefix/NoPluginFoundForPrefixException.java
@@ -40,29 +40,29 @@ public class NoPluginFoundForPrefixException
private static String format( LocalRepository localRepository, List<RemoteRepository> remoteRepositories )
{
- String repos = "[";
+ StringBuilder repos = new StringBuilder( "[" );
if ( localRepository != null )
{
- repos += localRepository.getId() + " (" + localRepository.getBasedir() + ")";
+ repos.append( localRepository.getId() ).append( " (" ).append( localRepository.getBasedir() ).append( ")" );
}
if ( remoteRepositories != null && !remoteRepositories.isEmpty() )
{
for ( RemoteRepository repository : remoteRepositories )
{
- repos += ", ";
+ repos.append( ", " );
if ( repository != null )
{
- repos += repository.getId() + " (" + repository.getUrl() + ")";
+ repos.append( repository.getId() ).append( " (" ).append( repository.getUrl() ).append( ")" );
}
}
}
- repos += "]";
+ repos.append( "]" );
- return repos;
+ return repos.toString();
}
}
diff --git a/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java b/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
index a45fa2c..565c934 100644
--- a/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
+++ b/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
@@ -1556,13 +1556,15 @@ public class DefaultModelBuilder
if ( importIds.contains( imported ) )
{
- String message = "The dependencies of type=pom and with scope=import form a cycle: ";
+ StringBuilder message =
+ new StringBuilder( "The dependencies of type=pom and with scope=import form a cycle: " );
for ( String modelId : importIds )
{
- message += modelId + " -> ";
+ message.append( modelId ).append( " -> " );
}
- message += imported;
- problems.add( new ModelProblemCollectorRequest( Severity.ERROR, Version.BASE ).setMessage( message ) );
+ message.append( imported );
+ problems.add( new ModelProblemCollectorRequest( Severity.ERROR, Version.BASE ).setMessage(
+ message.toString() ) );
return null;
}