You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by "nickva (via GitHub)" <gi...@apache.org> on 2025/04/22 04:47:14 UTC
[PR] Use new sets only in mango [couchdb]
nickva opened a new pull request, #5510:
URL: https://github.com/apache/couchdb/pull/5510
We already use new ones everywhere else and when switching to OTP 28 we got a bunch of failure do to various order changes, so make sure to use new ones everywhere.
Moreover, do not rely on implementation order of `sets:to_list()`, but sort the result to produce deterministic results regardless of the internal representation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use new sets only in mango [couchdb]
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva merged PR #5510:
URL: https://github.com/apache/couchdb/pull/5510
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use new sets only in mango [couchdb]
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on code in PR #5510:
URL: https://github.com/apache/couchdb/pull/5510#discussion_r2056285941
##########
src/mango/src/mango_cursor.erl:
##########
@@ -583,6 +585,9 @@ ddoc_name(<<"_design/", Name/binary>>) ->
ddoc_name(Name) ->
Name.
+set_from_list(KVs) ->
Review Comment:
Yeah, you're right, it's one line only but it's repeated 4 times, a util function would be nicer here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use new sets only in mango [couchdb]
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on PR #5510:
URL: https://github.com/apache/couchdb/pull/5510#issuecomment-2821525146
This is related to the effort to enable OTP 28 compatibility https://github.com/apache/couchdb/pull/5507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use new sets only in mango [couchdb]
Posted by "pgj (via GitHub)" <gi...@apache.org>.
pgj commented on code in PR #5510:
URL: https://github.com/apache/couchdb/pull/5510#discussion_r2055784447
##########
src/mango/src/mango_cursor.erl:
##########
@@ -583,6 +585,9 @@ ddoc_name(<<"_design/", Name/binary>>) ->
ddoc_name(Name) ->
Name.
+set_from_list(KVs) ->
Review Comment:
Would not it be better to move this definition to some shared utility module instead of duplicating its definition in multiple modules? One could include a similar wrapper for `sets:new([{version, 2}])` (as e.g. `set_new/0`) to extend consistency to the creation of sets.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org