[jira] [Commented] (HAMA-939) Refactoring which was implement using out-of-date status response

["Edward J. Yoon (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HAMA-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14568718#comment-14568718 ] 

Edward J. Yoon commented on HAMA-939:
-------------------------------------

In ApplicationMaster, RPC servers need to be stopped at finally block like below:

{code}
  public static void main(String[] args) throws IOException {
    boolean result = false;
    ApplicationMaster appMaster = new ApplicationMaster();
    
    try {
      LOG.info("Initializing ApplicationMaster");
      boolean doRun = appMaster.init(args);
      if (!doRun) {
        System.exit(0);
      }
      appMaster.run();
      result = appMaster.finish();
    } catch (Throwable t) {
      LOG.fatal("Error running ApplicationMaster", t);
      LogManager.shutdown();
      ExitUtil.terminate(1, t);
    } finally {
      appMaster.close();
    }
    
    if (result) {
      LOG.info("Application Master completed successfully. exiting");
      System.exit(0);
    } else {
      LOG.info("Application Master failed. exiting");
      System.exit(2);
    }
  }

   ....

  @Override
  public void close() throws IOException {
    this.clientServer.stop();
    this.taskServer.stop();
  }
{code}

> Refactoring which was implement using out-of-date status response
> -----------------------------------------------------------------
>
>                 Key: HAMA-939
>                 URL: https://issues.apache.org/jira/browse/HAMA-939
>             Project: Hama
>          Issue Type: Improvement
>          Components: yarn
>    Affects Versions: 0.7.0
>            Reporter: Minho Kim
>            Assignee: Minho Kim
>         Attachments: HAMA-939_v1.patch, HAMA-939_v2.patch, HAMA-939_v3.patch
>
>
> Status response handler of current YARN module is out of date.
> So I'm planning to modify status response handler using callback handler of RM and NM.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)