You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/16 12:38:42 UTC
[GitHub] [arrow-datafusion] Creampanda opened a new pull request, #4240: Fixing doc of the expression
Creampanda opened a new pull request, #4240:
URL: https://github.com/apache/arrow-datafusion/pull/4240
# Which issue does this PR close?
Closes #4231
Doc of the expression functionlog2 is incorrect
# Rationale for this change
Incorrect docs for some functions
# What changes are included in this PR?
# Are these changes tested?
Just changed some strings.
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #4240: Fixing doc of the expression
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #4240:
URL: https://github.com/apache/arrow-datafusion/pull/4240#issuecomment-1317708970
Benchmark runs are scheduled for baseline = 715ed5dd5c6b81bf3c1f40b111642bfb145685e8 and contender = 13127aed3750d28738aac54b248f3426bd983fdd. 13127aed3750d28738aac54b248f3426bd983fdd is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/9dadc5c2759e4332a90e411108d8f1cf...c8d9363445b24da1a917e62bd4632a58/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3f292868da574a33908cd40eb7603d75...98aee8e4adf24a6383a07a2cc2a63da8/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/34dc87434cd94f46860c9bb00fa69451...0051470b0cd44a9da8f31ec84900319b/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/6d1a4b8f1580410db81d532bb7b02b01...e83932336f18418c9e9b6f45e42ded2a/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] isidentical commented on a diff in pull request #4240: Fixing doc of the expression
Posted by GitBox <gi...@apache.org>.
isidentical commented on code in PR #4240:
URL: https://github.com/apache/arrow-datafusion/pull/4240#discussion_r1024080106
##########
datafusion/expr/src/expr_fn.rs:
##########
@@ -366,8 +366,8 @@ unary_scalar_expr!(Round, round, "round to nearest integer");
unary_scalar_expr!(Trunc, trunc, "truncate toward zero");
unary_scalar_expr!(Abs, abs, "absolute value");
unary_scalar_expr!(Signum, signum, "sign of the argument (-1, 0, +1) ");
-unary_scalar_expr!(Exp, exp, "base 2 logarithm");
-unary_scalar_expr!(Log2, log2, "base 10 logarithm");
+unary_scalar_expr!(Exp, exp, "exponent");
Review Comment:
Very minor thing (mainly for consistency), but since most of the functions here mirror the [Postgres documentation](https://www.postgresql.org/docs/7.1/functions-math.html), maybe we should use it for the `exp()` as well.
```suggestion
unary_scalar_expr!(Exp, exp, "exponential");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #4240: Fixing doc of the expression
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #4240:
URL: https://github.com/apache/arrow-datafusion/pull/4240#issuecomment-1317695986
Thank you very much @Creampanda and @isidentical
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #4240: Fixing doc of the expression
Posted by GitBox <gi...@apache.org>.
alamb merged PR #4240:
URL: https://github.com/apache/arrow-datafusion/pull/4240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org