You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/08 13:06:13 UTC

[GitHub] [spark] chummyhe89 opened a new pull request #24556: [SPARK-27641][CORE] Fix MetricsSystem to remove unregistered source correctly

chummyhe89 opened a new pull request #24556: [SPARK-27641][CORE] Fix MetricsSystem to remove unregistered source correctly
URL: https://github.com/apache/spark/pull/24556
 
 
   
   ## What changes were proposed in this pull request?
   
   * check whether the source is registered before remove it.
   * return the registered source from `LongAccumulatorSource` and `DoubleAccumulatorSource`'s register method,then we can remove it use `metricsSystem.removeSource`
   
   
   ## How was this patch tested?
   
   add new unit tests
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org