You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2018/05/14 07:50:58 UTC
[GitHub] chidaodezhongsheng commented on issue #1220: support shardingjdbc
database storage feature
chidaodezhongsheng commented on issue #1220: support shardingjdbc database storage feature
URL: https://github.com/apache/incubator-skywalking/pull/1220#issuecomment-388727682
@wu-sheng thanks a lot, I will resolve the conflicts and mentions.
技术部·架构部·林嘉琦
手机：18710075837
Email：linjiaqi@dangdang.com<ma...@dangdang.com>
QQ：928926755
发件人: 吴晟 Wu Sheng [mailto:notifications@github.com]
发送时间: 2018年5月14日 15:45
收件人: apache/incubator-skywalking
抄送: 林嘉琦; Mention
主题: Re: [apache/incubator-skywalking] support shardingjdbc database storage feature (#1220)
@wu-sheng commented on this pull request.
@chidaodezhongsheng<https://github.com/chidaodezhongsheng> The implementation codes are under incubating. So you will take charge. I just reviewed the licenses and documents related things.
Some things need to change.
________________________________
In apm-collector/apm-collector-boot/src/main/resources/application.yml<https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187851353>:
> + contextPath: /
+storage:
+ elasticsearch:
+ clusterName: CollectorDBCluster
+ clusterTransportSniffer: true
+ clusterNodes: localhost:9300
+ indexShardsNumber: 2
+ indexReplicasNumber: 0
+ highPerformanceMode: true
+ ttl: 7
+#storage:
+# h2:
+# url: jdbc:h2:~/memorydb
+# userName: sa
+#storage:
+# shardingjdbc:
ShardingJDBC is an incubating feature, no use cases yet. And none of the contributors are committer yet. So, by that, please don't put Sharding JDBC in default application.yml. Even it is under comments.
________________________________
In apm-dist/release-docs/LICENSE<https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187858208>:
> @@ -255,6 +256,7 @@ The text of each license is also included at licenses/LICENSE-[project].txt.
Apache: commons-configuration 1.8: https://github.com/apache/commons-configuration, Apache 2.0
Apache: commons-io 2.4: https://github.com/apache/commons-io, Apache 2.0
Apache: tomcat 8.5.27: https://github.com/apache/tomcat/tree/trunk, Apache 2.0
+ Apache: groovy 2.4.5-indy: https://github.com/apache/groovy, Apache 2.0
Groovy has a NOTICE file. Please change NOTICE in same folder. And follow the file structure. Ref here: https://github.com/apache/groovy/blob/master/NOTICE
________________________________
In docs/README.md<https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187858505>:
> - * [Agent or collector version upgrade](en/FAQ/Upgrade.md)
-
+## Documents
+[](README_ZH.md)<https://img.shields.io/badge/document-中文-blue.svg)%5d(README_ZH.md)>
+
+ * Getting Started
+ * [Quick start](en/Quick-start.md)
+ * [Supported middlewares, frameworks and libraries](Supported-list.md)
+ * [How to disable plugins?](en/How-to-disable-plugin.md)
+ * Advanced Features
+ * [Override settings through System.properties or System.env](en/Setting-override.md)
+ * [Direct uplink and disable naming discovery](en/Direct-uplink.md)
+ * [Open TLS](en/TLS.md)
+ * [Namespace Isolation](en/Namespace.md)
+ * [Token Authentication](en/Token-auth.md)
+ * [Open Database Sharding Storage](en/Shardingjdbc.md)
This should a section in Incubating Features. named: Use Sharding JDBC as storage implementor.
________________________________
In docs/en/Shardingjdbc.md<https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187858734>:
> @@ -0,0 +1,13 @@
+# Supported Database Sharding Storage
+Beside the default Elasticsearch storage, it also support the database sharding storage, it allow the users to store data in multiple databases.
+Note: it only supported MYSQL database sharding, and due to the license restrictions, the users need to import MYSQL Driver manually.
+
+## Supported version
+5.0.0-beta +
+
+## Requirement
+- Manually import MySQL Driver package mysql-connector-java-5.1.36.jar to collector-libs directory.
collector-libs is not the directory name.
________________________________
In docs/en/Shardingjdbc.md<https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187858863>:
> @@ -0,0 +1,13 @@
+# Supported Database Sharding Storage
+Beside the default Elasticsearch storage, it also support the database sharding storage, it allow the users to store data in multiple databases.
+Note: it only supported MYSQL database sharding, and due to the license restrictions, the users need to import MYSQL Driver manually.
+
+## Supported version
+5.0.0-beta +
+
+## Requirement
+- Manually import MySQL Driver package mysql-connector-java-5.1.36.jar to collector-libs directory.
+- In config/application.yml, close the elasticsearch configuration and open the shardingjdbc configuration, multiple data source configurations should be separated by Half Comma.
Considering the sharding settings have been remove from application.yml. please add the settings in here.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://github.com/apache/incubator-skywalking/pull/1220#pullrequestreview-119711946>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AbEqGIrpIAE3UB-ved15UgPFge5rUXwCks5tyTYRgaJpZM4T9MUe>.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services